From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YM9hG-0005aV-4E for qemu-devel@nongnu.org; Fri, 13 Feb 2015 01:25:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YM9hC-0007kb-T0 for qemu-devel@nongnu.org; Fri, 13 Feb 2015 01:25:50 -0500 Date: Fri, 13 Feb 2015 06:33:31 +0008 From: Jason Wang Message-Id: <1423808731.4864.0@smtp.corp.redhat.com> In-Reply-To: <1423738334-13545-1-git-send-email-armbru@redhat.com> References: <1423738334-13545-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Subject: Re: [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Michael Walle , Gerd Hoffmann , Stefan Hajnoczi On Thu, Feb 12, 2015 at 6:52 PM, Markus Armbruster wrote: > When I can't guess a handler's name, I have to look it up in > hmp-commands.hx. Happens often enough to annoy me. Let's make them > more predictable. > > Touches several subsystems because HMP command handlers are still > spread far and wide, but the changes are trivial. Speak up if you > want your subsystem's part routed through your tree rather than > -trivial. > > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Cc: Michael Walle > Cc: "Michael S. Tsirkin" > Cc: Gerd Hoffmann > Cc: Jason Wang > > Markus Armbruster (3): > hmp: Clean up declarations for long-gone info handlers > hmp: Name HMP command handler functions hmp_COMMAND() > hmp: Name HMP info handler functions hmp_info_SUBCOMMAND() > > block/block-backend.c | 6 +- > blockdev.c | 6 +- > device-hotplug.c | 2 +- > hmp-commands.hx | 86 +++++++++++++------------- > hmp.c | 6 +- > hmp.h | 6 +- > hw/core/loader.c | 2 +- > hw/intc/i8259.c | 4 +- > hw/intc/lm32_pic.c | 4 +- > hw/pci/pci-hotplug-old.c | 4 +- > hw/pci/pci-stub.c | 2 +- > hw/pci/pcie_aer.c | 2 +- > hw/sparc/sun4m.c | 4 +- > hw/usb/bus.c | 2 +- > hw/usb/host-libusb.c | 2 +- > hw/usb/host-stub.c | 2 +- > include/hw/i386/pc.h | 4 +- > include/hw/lm32/lm32_pic.h | 4 +- > include/hw/loader.h | 2 +- > include/hw/sparc/sun4m.h | 4 +- > include/hw/usb.h | 2 +- > include/migration/migration.h | 4 -- > include/monitor/qdev.h | 4 +- > include/net/net.h | 6 +- > include/net/slirp.h | 6 +- > include/sysemu/block-backend.h | 2 +- > include/sysemu/blockdev.h | 4 +- > include/sysemu/sysemu.h | 23 +++---- > include/ui/console.h | 2 +- > include/ui/qemu-spice.h | 3 - > monitor.c | 134 > ++++++++++++++++++++--------------------- > net/net.c | 6 +- > net/slirp.c | 6 +- > qdev-monitor.c | 4 +- > savevm.c | 6 +- > ui/input.c | 2 +- > vl.c | 4 +- > 37 files changed, 181 insertions(+), 191 deletions(-) > > -- > 1.9.3 > For net parts: Acked-by: Jason Wang