From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Programmingkid <programmingkidx@gmail.com>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] cocoa.m: Adds console items to the view menu
Date: Fri, 13 Feb 2015 08:45:51 +0100 [thread overview]
Message-ID: <1423813551.25119.6.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA_B3RMCHg-qfmt_14OSexO9WWjiiE6epDqQodHojJLZSA@mail.gmail.com>
Hi,
> We're going to need to automatically create and update
> the menu entries based on which consoles get created
> if we want this to work properly, I think. Gerd, any
> suggestions? Is there a hook for "list of active
> consoles has changed"?
No. consoles are not hotpluggable.
> What's the right way to get
> the printable name of a console?
gd_vc_gfx_init() has code for gfx consoles (qemu_console_is_graphic() ==
true).
There is nothing for text consoles.
Guess we should create a qemu_console_get_label() helper function in
ui/console.c, then move the code from gd_vc_gfx_init() to that place,
and for text consoles use QemuConsole->chr->label.
cheers,
Gerd
next prev parent reply other threads:[~2015-02-13 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 1:56 [Qemu-devel] [PATCH] cocoa.m: Adds console items to the view menu Programmingkid
2015-02-12 3:39 ` Peter Maydell
2015-02-12 16:10 ` Programmingkid
2015-02-12 22:03 ` Programmingkid
2015-02-13 7:45 ` Gerd Hoffmann [this message]
2015-02-13 15:37 ` Programmingkid
2015-02-14 5:48 ` [Qemu-devel] [PATCH v2] ui/cocoa.m: Adds console items to the View menu Programmingkid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423813551.25119.6.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).