qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PULL 04/14] mips: remove isa_mem_base usage
Date: Fri, 13 Feb 2015 10:02:02 +0000	[thread overview]
Message-ID: <1423821732-22542-5-git-send-email-leon.alrae@imgtec.com> (raw)
In-Reply-To: <1423821732-22542-1-git-send-email-leon.alrae@imgtec.com>

From: Hervé Poussineau <hpoussin@reactos.org>

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
 hw/mips/mips_r4k.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index 5b982f2..3e90e27 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -165,7 +165,8 @@ void mips_r4k_init(MachineState *machine)
     MemoryRegion *ram = g_new(MemoryRegion, 1);
     MemoryRegion *bios;
     MemoryRegion *iomem = g_new(MemoryRegion, 1);
-    MemoryRegion *isa = g_new(MemoryRegion, 1);
+    MemoryRegion *isa_io = g_new(MemoryRegion, 1);
+    MemoryRegion *isa_mem = g_new(MemoryRegion, 1);
     int bios_size;
     MIPSCPU *cpu;
     CPUMIPSState *env;
@@ -267,20 +268,20 @@ void mips_r4k_init(MachineState *machine)
     cpu_mips_irq_init_cpu(env);
     cpu_mips_clock_init(env);
 
+    /* ISA bus: IO space at 0x14000000, mem space at 0x10000000 */
+    memory_region_init_alias(isa_io, NULL, "isa-io",
+                             get_system_io(), 0, 0x00010000);
+    memory_region_init(isa_mem, NULL, "isa-mem", 0x01000000);
+    memory_region_add_subregion(get_system_memory(), 0x14000000, isa_io);
+    memory_region_add_subregion(get_system_memory(), 0x10000000, isa_mem);
+    isa_bus = isa_bus_new(NULL, isa_mem, get_system_io());
+
     /* The PIC is attached to the MIPS CPU INT0 pin */
-    isa_bus = isa_bus_new(NULL, get_system_memory(), get_system_io());
     i8259 = i8259_init(isa_bus, env->irq[2]);
     isa_bus_irqs(isa_bus, i8259);
 
     rtc_init(isa_bus, 2000, NULL);
 
-    /* Register 64 KB of ISA IO space at 0x14000000 */
-    memory_region_init_alias(isa, NULL, "isa_mmio",
-                             get_system_io(), 0, 0x00010000);
-    memory_region_add_subregion(get_system_memory(), 0x14000000, isa);
-
-    isa_mem_base = 0x10000000;
-
     pit = pit_init(isa_bus, 0x40, 0, NULL);
 
     for(i = 0; i < MAX_SERIAL_PORTS; i++) {
-- 
2.1.0

  parent reply	other threads:[~2015-02-13 10:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 10:01 [Qemu-devel] [PULL 00/14] target-mips queue Leon Alrae
2015-02-13 10:01 ` [Qemu-devel] [PULL 01/14] isa: add memory space parameter to isa_bus_new Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 02/14] jazz: do not explode QEMUMachineInitArgs structure Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 03/14] jazz: remove usage of isa_mem_base Leon Alrae
2015-02-13 10:02 ` Leon Alrae [this message]
2015-02-13 10:02 ` [Qemu-devel] [PULL 05/14] piix4: use PCI address space instead of system memory Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 06/14] gt64xxx: remove isa_mem_base usage Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 07/14] isa: remove isa_mem_base variable Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 08/14] target-mips: Make CP0.Status.CU1 read-only for the 5Kc and 5KEc processors Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 09/14] target-mips: fix detection of the end of the page during translation Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 10/14] target-mips: ll and lld cause AdEL exception for unaligned address Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 11/14] target-mips: use CP0EnLo_XI instead of magic number Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 12/14] target-mips: fix broken snapshotting Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 13/14] target-mips: pass 0 instead of -1 as rs in microMIPS LUI instruction Leon Alrae
2015-02-13 10:02 ` [Qemu-devel] [PULL 14/14] linux-user: correct stat structure in MIPS N32 Leon Alrae
2015-02-13 13:07 ` [Qemu-devel] [PULL 00/14] target-mips queue Peter Maydell
2015-02-13 13:46   ` Leon Alrae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423821732-22542-5-git-send-email-leon.alrae@imgtec.com \
    --to=leon.alrae@imgtec.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).