qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: mjrosato@linux.vnet.ibm.com, alex.williamson@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] pci: fix memory region lifecycle issues, document the rules
Date: Fri, 13 Feb 2015 15:57:08 +0100	[thread overview]
Message-ID: <1423839431-3563-1-git-send-email-pbonzini@redhat.com> (raw)

While these patches were originally in "part 3" of the RCU patches,
it turns out that the semantics they enforce are already important now
(reported by Alex Williamson and Matthew Rosato), so here they are!

Patch 1 fixes a MemoryRegion leak (and fixes it the right way, so that
the new lifecycle rules are respected!).

Patch 2 fixes a case where a memory region could be referenced (in
an RCU callback) when it had no parent, similar to the s390 case.

Patch 3 documents the MemoryRegion lifecycle rules now that (except for
s390, which Matthew is going to fix soon) QEMU actually follows them.

Please review and ACK.  Michael, okay to apply the first two through the
RCU tree?

Paolo

Paolo Bonzini (3):
  pcie: remove mmconfig memory leak and wrap mmconfig update with transaction
  pci: split shpc_cleanup and shpc_free
  docs: clarify memory region lifecycle

 docs/memory.txt                | 74 +++++++++++++++++++++++++++++++++---------
 hw/pci-bridge/pci_bridge_dev.c | 14 +++++---
 hw/pci/pcie_host.c             |  7 ++--
 hw/pci/shpc.c                  |  5 +++
 include/hw/pci/shpc.h          |  1 +
 5 files changed, 79 insertions(+), 22 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2015-02-13 14:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 14:57 Paolo Bonzini [this message]
2015-02-13 14:57 ` [Qemu-devel] [PATCH 1/3] pcie: remove mmconfig memory leak and wrap mmconfig update with transaction Paolo Bonzini
2015-02-16  8:33   ` Igor Mammedov
2015-02-16 15:45   ` Michael S. Tsirkin
2015-02-13 14:57 ` [Qemu-devel] [PATCH 2/3] pci: split shpc_cleanup and shpc_free Paolo Bonzini
2015-02-13 16:44   ` Matthew Rosato
2015-02-16 16:12   ` Michael S. Tsirkin
2015-02-13 14:57 ` [Qemu-devel] [PATCH 3/3] docs: clarify memory region lifecycle Paolo Bonzini
2015-02-13 16:43   ` Matthew Rosato
2015-02-16 16:12 ` [Qemu-devel] [PATCH 0/3] pci: fix memory region lifecycle issues, document the rules Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423839431-3563-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=mjrosato@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).