From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YND0J-0001gH-RO for qemu-devel@nongnu.org; Sun, 15 Feb 2015 23:09:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YND0F-0007iK-SB for qemu-devel@nongnu.org; Sun, 15 Feb 2015 23:09:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YND0F-0007iF-LP for qemu-devel@nongnu.org; Sun, 15 Feb 2015 23:09:47 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1G49jhS026400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 15 Feb 2015 23:09:46 -0500 From: Fam Zheng Date: Mon, 16 Feb 2015 12:09:40 +0800 Message-Id: <1424059780-7566-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Stefan Hajnoczi By default, we have ioeventfd enabled, so the IO request processing is in IO thread; in the vcpu thread, guest mode is returned to as quickly as possible, and completion is delivered via irqfd. Therefore this comment from the initial implementation is barely relevant. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 1a8a176..29c8d33 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -591,12 +591,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq) if (mrb.num_reqs) { virtio_blk_submit_multireq(s->blk, &mrb); } - - /* - * FIXME: Want to check for completions before returning to guest mode, - * so cached reads and writes are reported as quickly as possible. But - * that should be done in the generic block layer. - */ } static void virtio_blk_dma_restart_bh(void *opaque) -- 1.9.3