From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNH0Y-0002aZ-RE for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:26:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNH0X-0007wV-Hn for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:26:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNH0X-0007wI-BT for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:26:21 -0500 From: Gerd Hoffmann Date: Mon, 16 Feb 2015 09:25:59 +0100 Message-Id: <1424075165-25016-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1424075165-25016-1-git-send-email-kraxel@redhat.com> References: <1424075165-25016-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 1/7] vnc: fix qemu crash when not configure vnc option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gonglei , Gerd Hoffmann , Anthony Liguori From: Gonglei Add missing vnc options: to, ipv4, ipv6 and fix qemu crash. Reproducer: $ x86_64-softmmu/qemu-system-x86_64 qemu-system-x86_64: Invalid parameter 'to' Segmentation fault (core dumped) BTW the patch fix the below bug: https://bugs.launchpad.net/qemu/+bug/1414222 Signed-off-by: Gonglei Reviewed-by: Don Slutz Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 02552ee..90e8a88 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3272,6 +3272,15 @@ static QemuOptsList qemu_vnc_opts = { .name = "connections", .type = QEMU_OPT_NUMBER, },{ + .name = "to", + .type = QEMU_OPT_NUMBER, + },{ + .name = "ipv4", + .type = QEMU_OPT_BOOL, + },{ + .name = "ipv6", + .type = QEMU_OPT_BOOL, + },{ .name = "password", .type = QEMU_OPT_BOOL, },{ -- 1.8.3.1