From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNH0f-0002l4-EB for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:26:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNH0a-0007xa-KR for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:26:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNH0a-0007xP-Dt for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:26:24 -0500 From: Gerd Hoffmann Date: Mon, 16 Feb 2015 09:26:03 +0100 Message-Id: <1424075165-25016-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1424075165-25016-1-git-send-email-kraxel@redhat.com> References: <1424075165-25016-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 5/7] vnc: auto assian an id when calling change vnc qmp interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gonglei , Gerd Hoffmann , Luiz Capitulino From: Gonglei Only in this way, change vnc qmp interface can take effect, because qemu_opts_find(&qemu_vnc_opts, id) will return NULL in vnc_display_open(), It can't connect successfully vnc server forever. Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- qmp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qmp.c b/qmp.c index 6b2c4be..d701cff 100644 --- a/qmp.c +++ b/qmp.c @@ -387,6 +387,11 @@ static void qmp_change_vnc_listen(const char *target, Error **errp) qemu_opts_del(opts); } opts = vnc_parse_func(target); + if (!opts) { + return; + } + + vnc_auto_assign_id(olist, opts); vnc_display_open("default", errp); } -- 1.8.3.1