qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] vga: assert to "solve" qxl bug
Date: Mon, 16 Feb 2015 22:23:06 +0100	[thread overview]
Message-ID: <1424121788-24560-1-git-send-email-rkrcmar@redhat.com> (raw)

This is a first step in untangling the vga initialization.

[1/2] turns a runtime bug into a misconfiguration.
[2/2] will catch the same bug.

What would be nice to do, for starters:
 1) propagate recoverable errors (we might want some kind of fallback,
    but never without notifying the highest relevant level.)
 2) emit human-friendly messages
 3) add setters to do (4)-(7) in a sane way
 4) respect invalid user configurations (and abort)
 5) remove duplicate variables
 6) check numeric range of parameters
 7) couple dependent variables by invariants
    (or, better, just don't mess with them everywhere)

(Disclaimer: not on my TODO.)


Radim Krčmář (2):
  vga: abort instead of shrinking memory
  qxl: surface0 and ram_header should fit into vram

 hw/display/qxl.c |  2 ++
 hw/display/vga.c | 10 +++-------
 2 files changed, 5 insertions(+), 7 deletions(-)

-- 
2.3.0

             reply	other threads:[~2015-02-16 21:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 21:23 Radim Krčmář [this message]
2015-02-16 21:23 ` [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory Radim Krčmář
2015-02-17  8:00   ` Gerd Hoffmann
2015-02-17 10:29     ` Radim Krčmář
2015-02-17 10:37       ` Gerd Hoffmann
2015-02-17 10:48         ` Radim Krčmář
2015-02-17 10:51           ` Gerd Hoffmann
2015-02-17 11:15             ` Radim Krčmář
2015-02-16 21:23 ` [Qemu-devel] [PATCH 2/2] qxl: surface0 and ram_header should fit into vram Radim Krčmář
2015-02-17  8:02   ` Gerd Hoffmann
2015-02-17 10:31     ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424121788-24560-1-git-send-email-rkrcmar@redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).