Re: [Qemu-devel] [PATCH 2/4] ui/console: Removed unused functions

[Gerd Hoffmann <kraxel@redhat.com>]

On Mo, 2015-02-16 at 22:41 +0100, Thomas Huth wrote:
> Remove dpy_gfx_update_dirty(), qemu_console_get_head(),
> qemu_console_get_ui_info(), qemu_console_get_width(),
> qemu_console_get_height(), emu_console_displaystate(),
> qemu_different_endianness_pixelformat(), void cpkey(),
> qemu_pixman_linebuf_copy(), qemu_pixman_color(),
> emu_remove_kbd_event_handler() and vnc_stop_worker_thread()
> since they are completely unused.

Vetoing this one.  Some of them belong to work-in-progress bits and
should not be removed.

Also I think this kind of cleanup should be splitted into smaller
pieces, so it is easier to get specific bits back via "git revert"
should the need arise.

> -void dpy_gfx_update_dirty(QemuConsole *con,

Keep.

> -QemuUIInfo *qemu_console_get_ui_info(QemuConsole *con)

Keep.

> -int qemu_console_get_width(QemuConsole *con, int fallback)
> -int qemu_console_get_height(QemuConsole *con, int fallback)

Hmm, not sure.  Separate patch please.

> -DisplayState *qemu_console_displaystate(QemuConsole *console)

Ok.

> -PixelFormat qemu_different_endianness_pixelformat(int bpp)

Ok.

> -void cpkey(register unsigned long *into)

Ok.

> -void qemu_remove_kbd_event_handler(QEMUPutKbdEntry *entry)

Ok.

> -void qemu_input_handler_deactivate(QemuInputHandlerState *s)

Hmm, might be needed in the future.  Separate patch please.

> -/* copy linebuf to framebuffer */
> -void qemu_pixman_linebuf_copy(pixman_image_t *fb, int width, int x, int y,
> -                              pixman_image_t *linebuf)
> -{
> -    pixman_image_composite(PIXMAN_OP_SRC, linebuf, NULL, fb,
> -                           0, 0, 0, 0, x, y, width, 1);
> -}

Keep.

> -pixman_color_t qemu_pixman_color(PixelFormat *pf, uint32_t color)
> -{
> -    pixman_color_t c;
> -
> -    c.red   = ((color & pf->rmask) >> pf->rshift) << (16 - pf->rbits);
> -    c.green = ((color & pf->gmask) >> pf->gshift) << (16 - pf->gbits);
> -    c.blue  = ((color & pf->bmask) >> pf->bshift) << (16 - pf->bbits);
> -    c.alpha = ((color & pf->amask) >> pf->ashift) << (16 - pf->abits);
> -    return c;
> -}

Not sure.  Separate patch please.

> -void vnc_stop_worker_thread(void)

Probably ok.  Separate patch would be nice.

cheers,
  Gerd