From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNdQ3-0002qG-CV for qemu-devel@nongnu.org; Tue, 17 Feb 2015 03:22:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNdQ2-0004Nk-KJ for qemu-devel@nongnu.org; Tue, 17 Feb 2015 03:22:11 -0500 Message-ID: <1424161317.6014.14.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 17 Feb 2015 09:21:57 +0100 In-Reply-To: <1424122891-9390-3-git-send-email-thuth@linux.vnet.ibm.com> References: <1424122891-9390-1-git-send-email-thuth@linux.vnet.ibm.com> <1424122891-9390-3-git-send-email-thuth@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] ui/console: Removed unused functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Anthony Liguori On Mo, 2015-02-16 at 22:41 +0100, Thomas Huth wrote: > Remove dpy_gfx_update_dirty(), qemu_console_get_head(), > qemu_console_get_ui_info(), qemu_console_get_width(), > qemu_console_get_height(), emu_console_displaystate(), > qemu_different_endianness_pixelformat(), void cpkey(), > qemu_pixman_linebuf_copy(), qemu_pixman_color(), > emu_remove_kbd_event_handler() and vnc_stop_worker_thread() > since they are completely unused. Vetoing this one. Some of them belong to work-in-progress bits and should not be removed. Also I think this kind of cleanup should be splitted into smaller pieces, so it is easier to get specific bits back via "git revert" should the need arise. > -void dpy_gfx_update_dirty(QemuConsole *con, Keep. > -QemuUIInfo *qemu_console_get_ui_info(QemuConsole *con) Keep. > -int qemu_console_get_width(QemuConsole *con, int fallback) > -int qemu_console_get_height(QemuConsole *con, int fallback) Hmm, not sure. Separate patch please. > -DisplayState *qemu_console_displaystate(QemuConsole *console) Ok. > -PixelFormat qemu_different_endianness_pixelformat(int bpp) Ok. > -void cpkey(register unsigned long *into) Ok. > -void qemu_remove_kbd_event_handler(QEMUPutKbdEntry *entry) Ok. > -void qemu_input_handler_deactivate(QemuInputHandlerState *s) Hmm, might be needed in the future. Separate patch please. > -/* copy linebuf to framebuffer */ > -void qemu_pixman_linebuf_copy(pixman_image_t *fb, int width, int x, int y, > - pixman_image_t *linebuf) > -{ > - pixman_image_composite(PIXMAN_OP_SRC, linebuf, NULL, fb, > - 0, 0, 0, 0, x, y, width, 1); > -} Keep. > -pixman_color_t qemu_pixman_color(PixelFormat *pf, uint32_t color) > -{ > - pixman_color_t c; > - > - c.red = ((color & pf->rmask) >> pf->rshift) << (16 - pf->rbits); > - c.green = ((color & pf->gmask) >> pf->gshift) << (16 - pf->gbits); > - c.blue = ((color & pf->bmask) >> pf->bshift) << (16 - pf->bbits); > - c.alpha = ((color & pf->amask) >> pf->ashift) << (16 - pf->abits); > - return c; > -} Not sure. Separate patch please. > -void vnc_stop_worker_thread(void) Probably ok. Separate patch would be nice. cheers, Gerd