From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNl3N-0005tp-0l for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:31:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNl3G-0001so-QC for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:31:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNl3G-0001sf-IY for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:31:10 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1HGV98S001256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 17 Feb 2015 11:31:10 -0500 From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Date: Tue, 17 Feb 2015 17:30:53 +0100 Message-Id: <1424190653-29139-5-git-send-email-rkrcmar@redhat.com> In-Reply-To: <1424190653-29139-1-git-send-email-rkrcmar@redhat.com> References: <1424190653-29139-1-git-send-email-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 4/4] vga: refactor vram_size clamping and rounding List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Make the code a bit more obvious. We don't have min/max, so a general helper for clamp probably isn't acceptable either. Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 --- v2: kept rounding and clamping (was [v1 1/2]) hw/display/vga.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 13f34f950d5a..7e0c01dc57fa 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -2095,6 +2095,17 @@ static const GraphicHwOps vga_ops =3D { .text_update =3D vga_update_text, }; =20 +static inline uint32_t uint_clamp(uint32_t val, uint32_t vmin, uint32_t = vmax) +{ + if (val < vmin) { + return vmin; + } + if (val > vmax) { + return vmax; + } + return val; +} + void vga_common_init(VGACommonState *s, Object *obj, bool global_vmstate= ) { int i, j, v, b; @@ -2122,13 +2133,10 @@ void vga_common_init(VGACommonState *s, Object *o= bj, bool global_vmstate) expand4to8[i] =3D v; } =20 - /* valid range: 1 MB -> 512 MB */ - s->vram_size =3D 1024 * 1024; - while (s->vram_size < (s->vram_size_mb << 20) && - s->vram_size < (512 << 20)) { - s->vram_size <<=3D 1; - } - s->vram_size_mb =3D s->vram_size >> 20; + s->vram_size_mb =3D uint_clamp(s->vram_size_mb, 1, 512); + s->vram_size_mb =3D pow2ceil(s->vram_size_mb); + s->vram_size =3D s->vram_size_mb << 20; + if (!s->vbe_size) { s->vbe_size =3D s->vram_size; } --=20 2.3.0