qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 3/8] usb: Do not prefix error_setg() messages with "Error: "
Date: Wed, 18 Feb 2015 11:08:20 +0100	[thread overview]
Message-ID: <1424254105-30237-4-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1424254105-30237-1-git-send-email-kraxel@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Because it produces beauties like

    (qemu) usb_add mouse
    Failed to initialize USB device 'usb-mouse': Error: tried to attach usb device QEMU USB Mouse to a bus with no free ports

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 3f69fe1..3e85afe 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -412,7 +412,7 @@ void usb_claim_port(USBDevice *dev, Error **errp)
             }
         }
         if (port == NULL) {
-            error_setg(errp, "Error: usb port %s (bus %s) not found (in use?)",
+            error_setg(errp, "usb port %s (bus %s) not found (in use?)",
                        dev->port_path, bus->qbus.name);
             return;
         }
@@ -422,7 +422,7 @@ void usb_claim_port(USBDevice *dev, Error **errp)
             usb_create_simple(bus, "usb-hub");
         }
         if (bus->nfree == 0) {
-            error_setg(errp, "Error: tried to attach usb device %s to a bus "
+            error_setg(errp, "tried to attach usb device %s to a bus "
                        "with no free ports", dev->product_desc);
             return;
         }
-- 
1.8.3.1

  parent reply	other threads:[~2015-02-18 10:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 10:08 [Qemu-devel] [PULL 0/8] usb: error handling fixes from Markus, make sysbus ehci arm-only Gerd Hoffmann
2015-02-18 10:08 ` [Qemu-devel] [PULL 1/8] usb: usb_create() can't fail, drop useless error handling Gerd Hoffmann
2015-02-18 10:08 ` [Qemu-devel] [PULL 2/8] usb: Improve -usbdevice error reporting a bit Gerd Hoffmann
2015-02-18 10:08 ` Gerd Hoffmann [this message]
2015-02-18 10:08 ` [Qemu-devel] [PULL 4/8] usb: Suppress bogus error when automatic usb-hub creation fails Gerd Hoffmann
2015-02-18 10:08 ` [Qemu-devel] [PULL 5/8] usb: Change usb_create_simple() to abort on failure Gerd Hoffmann
2015-02-18 10:08 ` [Qemu-devel] [PULL 6/8] r2d: Don't use legacy -usbdevice support for setting up board Gerd Hoffmann
2015-02-18 10:08 ` [Qemu-devel] [PULL 7/8] PPC: " Gerd Hoffmann
2015-02-18 10:08 ` [Qemu-devel] [PULL 8/8] Make sysbus EHCI devices ARM only by default Gerd Hoffmann
2015-02-25 13:13 ` [Qemu-devel] [PULL 0/8] usb: error handling fixes from Markus, make sysbus ehci arm-only Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424254105-30237-4-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).