From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35658)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YO1wH-0002PV-Sn
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 05:33:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YO1wD-0007pN-Ql
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 05:33:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57063)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YO1wD-0007pJ-KO
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 05:33:01 -0500
Message-ID: <1424255575.6014.54.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 18 Feb 2015 11:32:55 +0100
In-Reply-To: <1424163833.6014.25.camel@nilsson.home.kraxel.org>
References: <1424104405-18874-1-git-send-email-kraxel@redhat.com>
	<1424104405-18874-2-git-send-email-kraxel@redhat.com>
	<20150217051230.GA9763@fam-t430.nay.redhat.com>
	<1424161415.6014.15.camel@nilsson.home.kraxel.org>
	<20150217084250.GA20039@redhat.com>
	<1424163833.6014.25.camel@nilsson.home.kraxel.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/4] virtio-pci: add flags to
 enable/disable legacy/modern
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Di, 2015-02-17 at 10:03 +0100, Gerd Hoffmann wrote:
> On Di, 2015-02-17 at 09:42 +0100, Michael S. Tsirkin wrote:
> > On Tue, Feb 17, 2015 at 09:23:35AM +0100, Gerd Hoffmann wrote:
> > >   Hi,
> > > 
> > > > Should we forbid setting both legacy and modern at the same time?
> > > 
> > > No, this is explicitly allowed in the spec and it is needed for the
> > > transition from legacy to modern.
> > > 
> > > cheers,
> > >   Gerd
> > 
> > But !legacy && !modern aren't legal together, correct?
> 
> That doesn't make sense indeed.

What is the state of markus "convert pci to realize" patch series btw?  

Convert virtio-pci too, then throw an error in virtio_pci_realize would
be the best way to catch this I think.

cheers,
  Gerd