qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 10/11] qemu-img: Avoid qerror_report_err() outside QMP command handlers
Date: Wed, 18 Feb 2015 11:34:21 +0100	[thread overview]
Message-ID: <1424255662-5393-11-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1424255662-5393-1-git-send-email-armbru@redhat.com>

qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP.  It should not be used
elsewhere.  Replace by error_report_err().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 qemu-img.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c
index 97d04bd..25b1369 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -889,8 +889,7 @@ done:
     blk_unref(blk);
 
     if (local_err) {
-        qerror_report_err(local_err);
-        error_free(local_err);
+        error_report_err(local_err);
         return 1;
     }
 
-- 
1.9.3

  parent reply	other threads:[~2015-02-18 10:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 10:34 [Qemu-devel] [PULL 00/11] Clean up around error_get_pretty(), qerror_report_err() Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 01/11] vhost-scsi: Improve error reporting for invalid vhostfd Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 02/11] error: New convenience function error_report_err() Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 03/11] error: Use error_report_err() where appropriate Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 04/11] monitor: Clean up around monitor_handle_fd_param() Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 05/11] monitor: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 06/11] net: " Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 07/11] numa: " Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 08/11] tpm: " Markus Armbruster
2015-02-18 10:34 ` [Qemu-devel] [PULL 09/11] vl: " Markus Armbruster
2015-02-18 10:34 ` Markus Armbruster [this message]
2015-02-18 10:34 ` [Qemu-devel] [PULL 11/11] qemu-char: " Markus Armbruster
2015-02-18 11:02 ` [Qemu-devel] [PULL 00/11] Clean up around error_get_pretty(), qerror_report_err() Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424255662-5393-11-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).