From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO9G3-0000OK-Kh for qemu-devel@nongnu.org; Wed, 18 Feb 2015 13:22:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO9G0-0005Gh-FY for qemu-devel@nongnu.org; Wed, 18 Feb 2015 13:21:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO9G0-0005Ga-8g for qemu-devel@nongnu.org; Wed, 18 Feb 2015 13:21:56 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1IILtoj010478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 18 Feb 2015 13:21:55 -0500 From: Markus Armbruster Date: Wed, 18 Feb 2015 19:21:52 +0100 Message-Id: <1424283712-476-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, quintela@redhat.com qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in process_incoming_migration_co(). Signed-off-by: Markus Armbruster --- Based on [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err() migration/migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index b3adbc6..6a5e3f9 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -106,8 +106,7 @@ static void process_incoming_migration_co(void *opaque) /* Make sure all file formats flush their mutable metadata */ bdrv_invalidate_cache_all(&local_err); if (local_err) { - qerror_report_err(local_err); - error_free(local_err); + error_report_err(local_err); exit(EXIT_FAILURE); } -- 1.9.3