* [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers
@ 2015-02-18 18:21 Markus Armbruster
2015-02-18 20:00 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Armbruster @ 2015-02-18 18:21 UTC (permalink / raw)
To: qemu-devel; +Cc: amit.shah, quintela
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in
process_incoming_migration_co().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
Based on
[PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err()
migration/migration.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index b3adbc6..6a5e3f9 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -106,8 +106,7 @@ static void process_incoming_migration_co(void *opaque)
/* Make sure all file formats flush their mutable metadata */
bdrv_invalidate_cache_all(&local_err);
if (local_err) {
- qerror_report_err(local_err);
- error_free(local_err);
+ error_report_err(local_err);
exit(EXIT_FAILURE);
}
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers
2015-02-18 18:21 [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
@ 2015-02-18 20:00 ` Eric Blake
2015-02-18 23:09 ` Juan Quintela
2015-03-17 12:42 ` Juan Quintela
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2015-02-18 20:00 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: amit.shah, quintela
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On 02/18/2015 11:21 AM, Markus Armbruster wrote:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP. It should not be used
> elsewhere. Replace by error_report_err() in
> process_incoming_migration_co().
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Based on
> [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err()
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> migration/migration.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index b3adbc6..6a5e3f9 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -106,8 +106,7 @@ static void process_incoming_migration_co(void *opaque)
> /* Make sure all file formats flush their mutable metadata */
> bdrv_invalidate_cache_all(&local_err);
> if (local_err) {
> - qerror_report_err(local_err);
> - error_free(local_err);
> + error_report_err(local_err);
> exit(EXIT_FAILURE);
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers
2015-02-18 18:21 [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
2015-02-18 20:00 ` Eric Blake
@ 2015-02-18 23:09 ` Juan Quintela
2015-03-17 12:42 ` Juan Quintela
2 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2015-02-18 23:09 UTC (permalink / raw)
To: Markus Armbruster; +Cc: amit.shah, qemu-devel
Markus Armbruster <armbru@redhat.com> wrote:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP. It should not be used
> elsewhere. Replace by error_report_err() in
> process_incoming_migration_co().
I trust you & eric
Included, thanks.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Based on
> [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err()
>
> migration/migration.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index b3adbc6..6a5e3f9 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -106,8 +106,7 @@ static void process_incoming_migration_co(void *opaque)
> /* Make sure all file formats flush their mutable metadata */
> bdrv_invalidate_cache_all(&local_err);
> if (local_err) {
> - qerror_report_err(local_err);
> - error_free(local_err);
> + error_report_err(local_err);
> exit(EXIT_FAILURE);
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers
2015-02-18 18:21 [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
2015-02-18 20:00 ` Eric Blake
2015-02-18 23:09 ` Juan Quintela
@ 2015-03-17 12:42 ` Juan Quintela
2 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2015-03-17 12:42 UTC (permalink / raw)
To: Markus Armbruster; +Cc: amit.shah, qemu-devel
Markus Armbruster <armbru@redhat.com> wrote:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP. It should not be used
> elsewhere. Replace by error_report_err() in
> process_incoming_migration_co().
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-17 12:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-18 18:21 [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
2015-02-18 20:00 ` Eric Blake
2015-02-18 23:09 ` Juan Quintela
2015-03-17 12:42 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).