qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v7 19/25] qcow2: Use abort() instead of assert(false)
Date: Wed, 18 Feb 2015 17:40:54 -0500	[thread overview]
Message-ID: <1424299260-1763-10-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1424299260-1763-1-git-send-email-mreitz@redhat.com>

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/qcow2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 0548248..6283a1c 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2729,9 +2729,9 @@ static int qcow2_amend_options(BlockDriverState *bs, QemuOpts *opts,
             error_report("Cannot change refcount entry width");
             return -ENOTSUP;
         } else {
-            /* if this assertion fails, this probably means a new option was
+            /* if this point is reached, this probably means a new option was
              * added without having it covered here */
-            assert(false);
+            abort();
         }
 
         desc++;
-- 
2.1.0

  parent reply	other threads:[~2015-02-18 22:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 22:40 [Qemu-devel] [PATCH v7 00/25] qcow2: Support refcount orders != 4 Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 11/25] qcow2: refcount_order parameter for qcow2_create2 Max Reitz
2015-02-19  2:51   ` Eric Blake
2015-02-19 14:01     ` Max Reitz
2015-02-19 23:15       ` Eric Blake
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 12/25] qcow2: Use symbolic macros in qcow2_amend_options Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 13/25] iotests: Prepare for refcount_bits option Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 14/25] qcow2: Allow creation with refcount order != 4 Max Reitz
2015-02-19 23:19   ` Eric Blake
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 15/25] iotests: Add test for different refcount widths Max Reitz
2015-02-19 23:22   ` Eric Blake
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 16/25] progress: Allow regressing progress Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 17/25] block: Add opaque value to the amend CB Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 18/25] qcow2: Use error_report() in qcow2_amend_options() Max Reitz
2015-02-18 22:40 ` Max Reitz [this message]
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 20/25] qcow2: Split upgrade/downgrade paths for amend Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 21/25] qcow2: Use intermediate helper CB " Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 22/25] qcow2: Add function for refcount order amendment Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 23/25] qcow2: Invoke refcount order amendment function Max Reitz
2015-02-18 22:40 ` [Qemu-devel] [PATCH v7 24/25] qcow2: Point to amend function in check Max Reitz
2015-02-18 22:41 ` [Qemu-devel] [PATCH v7 25/25] iotests: Extend test 112 for qemu-img amend Max Reitz
2015-02-19 23:24   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424299260-1763-10-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).