qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Fam Zheng" <famz@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	blauwirbel@gmail.com, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	=?UTF-8?q?Llu=C3=ADs=20Vilanova?= <vilanova@ac.upc.edu>
Subject: [Qemu-devel] [PATCH 1/2] Makefile: don't silence mak file test with V=1
Date: Thu, 19 Feb 2015 08:48:46 +0100	[thread overview]
Message-ID: <1424332114-13440-1-git-send-email-mst@redhat.com> (raw)

V=1 should show what's going on, it's not nice
to silence things unconditionally.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 6817c6f..84ca8be 100644
--- a/Makefile
+++ b/Makefile
@@ -110,7 +110,7 @@ endif
 
 %/config-devices.mak: default-configs/%.mak
 	$(call quiet-command,$(SHELL) $(SRC_PATH)/scripts/make_device_config.sh $@ $<, "  GEN   $@")
-	@if test -f $@; then \
+	$(call quiet-command, if test -f $@; then \
 	  if cmp -s $@.old $@; then \
 	    mv $@.tmp $@; \
 	    cp -p $@ $@.old; \
@@ -126,7 +126,7 @@ endif
 	 else \
 	  mv $@.tmp $@; \
 	  cp -p $@ $@.old; \
-	 fi
+	 fi, "  TEST $@");
 
 defconfig:
 	rm -f config-all-devices.mak $(SUBDIR_DEVICES_MAK)
-- 
MST

             reply	other threads:[~2015-02-19  7:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19  7:48 Michael S. Tsirkin [this message]
2015-02-19  7:48 ` [Qemu-devel] [PATCH 2/2] Makefile.target: binary depends on config-devices Michael S. Tsirkin
2015-02-25  6:35   ` Fam Zheng
2015-02-27 18:41   ` Paolo Bonzini
2015-02-25  6:34 ` [Qemu-devel] [PATCH 1/2] Makefile: don't silence mak file test with V=1 Fam Zheng
2015-02-27 18:40 ` Paolo Bonzini
2015-02-28  0:57   ` Fam Zheng
2015-03-02 15:52     ` Eric Blake
2015-03-02 16:22       ` Paolo Bonzini
2015-02-28 18:50   ` Michael S. Tsirkin
2015-03-11 17:24   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424332114-13440-1-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=famz@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).