qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: [Qemu-devel] [PATCH] pc: acpi: get rid of IASL warnings in MCRS method
Date: Thu, 19 Feb 2015 13:49:10 +0000	[thread overview]
Message-ID: <1424353750-26485-1-git-send-email-imammedo@redhat.com> (raw)

Newer IASL produces a bunch of false warnings like:
        ,, MW32, AddressRangeMemory, TypeStatic)
            Object is not referenced ^  (Name is within method [MCRS])

Caused by local integer constant name DescriptorName
in DWordMemory resource macro, it appears that compiler creates
a name for each of the fields of DWordMemory resource macro
if optional DescriptorName is provided and the complains
about not used ones.

So silence compiler by getting rid of DescriptorName in
MW[64|23] resource macros and use numeric field offsets
for referencing fields in MW32 buffer as it's already done
for MW64.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/i386/acpi-dsdt-mem-hotplug.dsl | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/i386/acpi-dsdt-mem-hotplug.dsl b/hw/i386/acpi-dsdt-mem-hotplug.dsl
index 2a36c47..4d693e3 100644
--- a/hw/i386/acpi-dsdt-mem-hotplug.dsl
+++ b/hw/i386/acpi-dsdt-mem-hotplug.dsl
@@ -105,7 +105,7 @@
                     0xFFFFFFFFFFFFFFFE,        // Address Range Maximum
                     0x0000000000000000,        // Address Translation Offset
                     0xFFFFFFFFFFFFFFFF,        // Address Length
-                    ,, MW64, AddressRangeMemory, TypeStatic)
+                    ,,, AddressRangeMemory, TypeStatic)
                 })
 
                 CreateDWordField(MR64, 14, MINL)
@@ -140,11 +140,11 @@
                         0xFFFFFFFE,        // Address Range Maximum
                         0x00000000,        // Address Translation Offset
                         0xFFFFFFFF,        // Address Length
-                        ,, MW32, AddressRangeMemory, TypeStatic)
+                        ,,, AddressRangeMemory, TypeStatic)
                     })
-                    CreateDWordField(MR32, MW32._MIN, MIN)
-                    CreateDWordField(MR32, MW32._MAX, MAX)
-                    CreateDWordField(MR32, MW32._LEN, LEN)
+                    CreateDWordField(MR32, 10, MIN)
+                    CreateDWordField(MR32, 14, MAX)
+                    CreateDWordField(MR32, 22, LEN)
                     Store(MINL, MIN)
                     Store(MAXL, MAX)
                     Store(LENL, LEN)
-- 
1.8.3.1

                 reply	other threads:[~2015-02-19 13:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424353750-26485-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).