From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YORTk-0006os-LQ for qemu-devel@nongnu.org; Thu, 19 Feb 2015 08:49:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YORTg-0006X2-Jt for qemu-devel@nongnu.org; Thu, 19 Feb 2015 08:49:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YORTg-0006Wc-BD for qemu-devel@nongnu.org; Thu, 19 Feb 2015 08:49:16 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1JDnF8d009288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 19 Feb 2015 08:49:15 -0500 From: Igor Mammedov Date: Thu, 19 Feb 2015 13:49:10 +0000 Message-Id: <1424353750-26485-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH] pc: acpi: get rid of IASL warnings in MCRS method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com Newer IASL produces a bunch of false warnings like: ,, MW32, AddressRangeMemory, TypeStatic) Object is not referenced ^ (Name is within method [MCRS]) Caused by local integer constant name DescriptorName in DWordMemory resource macro, it appears that compiler creates a name for each of the fields of DWordMemory resource macro if optional DescriptorName is provided and the complains about not used ones. So silence compiler by getting rid of DescriptorName in MW[64|23] resource macros and use numeric field offsets for referencing fields in MW32 buffer as it's already done for MW64. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt-mem-hotplug.dsl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/i386/acpi-dsdt-mem-hotplug.dsl b/hw/i386/acpi-dsdt-mem-hotplug.dsl index 2a36c47..4d693e3 100644 --- a/hw/i386/acpi-dsdt-mem-hotplug.dsl +++ b/hw/i386/acpi-dsdt-mem-hotplug.dsl @@ -105,7 +105,7 @@ 0xFFFFFFFFFFFFFFFE, // Address Range Maximum 0x0000000000000000, // Address Translation Offset 0xFFFFFFFFFFFFFFFF, // Address Length - ,, MW64, AddressRangeMemory, TypeStatic) + ,,, AddressRangeMemory, TypeStatic) }) CreateDWordField(MR64, 14, MINL) @@ -140,11 +140,11 @@ 0xFFFFFFFE, // Address Range Maximum 0x00000000, // Address Translation Offset 0xFFFFFFFF, // Address Length - ,, MW32, AddressRangeMemory, TypeStatic) + ,,, AddressRangeMemory, TypeStatic) }) - CreateDWordField(MR32, MW32._MIN, MIN) - CreateDWordField(MR32, MW32._MAX, MAX) - CreateDWordField(MR32, MW32._LEN, LEN) + CreateDWordField(MR32, 10, MIN) + CreateDWordField(MR32, 14, MAX) + CreateDWordField(MR32, 22, LEN) Store(MINL, MIN) Store(MAXL, MAX) Store(LENL, LEN) -- 1.8.3.1