[Qemu-devel] [PATCH] pc: acpi: get rid of IASL warnings in MCRS method

[Qemu-devel] [PATCH] pc: acpi: get rid of IASL warnings in MCRS method

[Igor Mammedov]

Newer IASL produces a bunch of false warnings like:
        ,, MW32, AddressRangeMemory, TypeStatic)
            Object is not referenced ^  (Name is within method [MCRS])

Caused by local integer constant name DescriptorName
in DWordMemory resource macro, it appears that compiler creates
a name for each of the fields of DWordMemory resource macro
if optional DescriptorName is provided and the complains
about not used ones.

So silence compiler by getting rid of DescriptorName in
MW[64|23] resource macros and use numeric field offsets
for referencing fields in MW32 buffer as it's already done
for MW64.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/i386/acpi-dsdt-mem-hotplug.dsl | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/i386/acpi-dsdt-mem-hotplug.dsl b/hw/i386/acpi-dsdt-mem-hotplug.dsl
index 2a36c47..4d693e3 100644
--- a/hw/i386/acpi-dsdt-mem-hotplug.dsl
+++ b/hw/i386/acpi-dsdt-mem-hotplug.dsl
@@ -105,7 +105,7 @@
                     0xFFFFFFFFFFFFFFFE,        // Address Range Maximum
                     0x0000000000000000,        // Address Translation Offset
                     0xFFFFFFFFFFFFFFFF,        // Address Length
-                    ,, MW64, AddressRangeMemory, TypeStatic)
+                    ,,, AddressRangeMemory, TypeStatic)
                 })
 
                 CreateDWordField(MR64, 14, MINL)
@@ -140,11 +140,11 @@
                         0xFFFFFFFE,        // Address Range Maximum
                         0x00000000,        // Address Translation Offset
                         0xFFFFFFFF,        // Address Length
-                        ,, MW32, AddressRangeMemory, TypeStatic)
+                        ,,, AddressRangeMemory, TypeStatic)
                     })
-                    CreateDWordField(MR32, MW32._MIN, MIN)
-                    CreateDWordField(MR32, MW32._MAX, MAX)
-                    CreateDWordField(MR32, MW32._LEN, LEN)
+                    CreateDWordField(MR32, 10, MIN)
+                    CreateDWordField(MR32, 14, MAX)
+                    CreateDWordField(MR32, 22, LEN)
                     Store(MINL, MIN)
                     Store(MAXL, MAX)
                     Store(LENL, LEN)
-- 
1.8.3.1