qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@linux.vnet.ibm.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@linux.vnet.ibm.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 3/5] ui/vnc: Remove vnc_stop_worker_thread()
Date: Thu, 19 Feb 2015 18:12:21 +0100	[thread overview]
Message-ID: <1424365943-27563-4-git-send-email-thuth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1424365943-27563-1-git-send-email-thuth@linux.vnet.ibm.com>

This function is not used anymore, let's remove it.

Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@amazon.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/vnc-jobs.c |   13 -------------
 ui/vnc-jobs.h |    1 -
 2 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index 68f3d77..c8ee203 100644
--- a/ui/vnc-jobs.c
+++ b/ui/vnc-jobs.c
@@ -342,16 +342,3 @@ void vnc_start_worker_thread(void)
                        QEMU_THREAD_DETACHED);
     queue = q; /* Set global queue */
 }
-
-void vnc_stop_worker_thread(void)
-{
-    if (!vnc_worker_thread_running())
-        return ;
-
-    /* Remove all jobs and wake up the thread */
-    vnc_lock_queue(queue);
-    queue->exit = true;
-    vnc_unlock_queue(queue);
-    vnc_jobs_clear(NULL);
-    qemu_cond_broadcast(&queue->cond);
-}
diff --git a/ui/vnc-jobs.h b/ui/vnc-jobs.h
index 31da103..044bf9f 100644
--- a/ui/vnc-jobs.h
+++ b/ui/vnc-jobs.h
@@ -40,7 +40,6 @@ void vnc_jobs_join(VncState *vs);
 
 void vnc_jobs_consume_buffer(VncState *vs);
 void vnc_start_worker_thread(void);
-void vnc_stop_worker_thread(void);
 
 /* Locks */
 static inline int vnc_trylock_display(VncDisplay *vd)
-- 
1.7.1

  parent reply	other threads:[~2015-02-19 17:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 17:12 [Qemu-devel] [PATCH v2 0/5] Remove unused functions Thomas Huth
2015-02-19 17:12 ` [Qemu-devel] [PATCH 1/5] migration: " Thomas Huth
2015-02-24  9:28   ` Amit Shah
2015-02-24 16:28     ` Thomas Huth
2015-03-02  6:44       ` Amit Shah
2015-02-19 17:12 ` [Qemu-devel] [PATCH 2/5] ui: Removed " Thomas Huth
2015-02-23  7:19   ` Gerd Hoffmann
2015-02-19 17:12 ` Thomas Huth [this message]
2015-02-23  7:19   ` [Qemu-devel] [PATCH 3/5] ui/vnc: Remove vnc_stop_worker_thread() Gerd Hoffmann
2015-02-19 17:12 ` [Qemu-devel] [PATCH 4/5] util: Remove unused functions Thomas Huth
2015-02-19 17:12 ` [Qemu-devel] [PATCH 5/5] xen: Remove xen_cmos_set_s3_resume() Thomas Huth
2015-02-25 16:47   ` Stefano Stabellini
2015-02-28  9:16 ` [Qemu-devel] [PATCH v2 0/5] Remove unused functions Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424365943-27563-4-git-send-email-thuth@linux.vnet.ibm.com \
    --to=thuth@linux.vnet.ibm.com \
    --cc=aliguori@amazon.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).