From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOgxX-0002PD-8k for qemu-devel@nongnu.org; Fri, 20 Feb 2015 01:21:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOgxT-0008Ob-7g for qemu-devel@nongnu.org; Fri, 20 Feb 2015 01:21:07 -0500 Received: from mail-qa0-x22b.google.com ([2607:f8b0:400d:c00::22b]:47178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOgxT-0008OX-24 for qemu-devel@nongnu.org; Fri, 20 Feb 2015 01:21:03 -0500 Received: by mail-qa0-f43.google.com with SMTP id bm13so10861346qab.2 for ; Thu, 19 Feb 2015 22:21:02 -0800 (PST) Sender: Richard Henderson From: Richard Henderson Date: Thu, 19 Feb 2015 22:20:29 -0800 Message-Id: <1424413229-7755-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH] target-ppc: Use movcond in isel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: agraf@suse.de Signed-off-by: Richard Henderson --- target-ppc/translate.c | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) --- Note that this is relative to an outstanding TCG patch set. The full tree is at git://github.com/rth7680/qemu.git ppc-movcond r~ --- diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 98165e9..278c266 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -753,27 +753,20 @@ static void gen_cmpli(DisasContext *ctx) /* isel (PowerPC 2.03 specification) */ static void gen_isel(DisasContext *ctx) { - TCGLabel *l1, *l2; uint32_t bi = rC(ctx->opcode); - uint32_t mask; - TCGv_i32 t0; + uint32_t mask = 0x08 >> (bi & 0x03); + TCGv t0 = tcg_temp_new(); + TCGv zr; - l1 = gen_new_label(); - l2 = gen_new_label(); + tcg_gen_extu_i32_tl(t0, cpu_crf[bi >> 2]); + tcg_gen_andi_tl(t0, t0, mask); - mask = 0x08 >> (bi & 0x03); - t0 = tcg_temp_new_i32(); - tcg_gen_andi_i32(t0, cpu_crf[bi >> 2], mask); - tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1); - if (rA(ctx->opcode) == 0) - tcg_gen_movi_tl(cpu_gpr[rD(ctx->opcode)], 0); - else - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - tcg_gen_br(l2); - gen_set_label(l1); - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]); - gen_set_label(l2); - tcg_temp_free_i32(t0); + zr = tcg_const_tl(0); + tcg_gen_movcond_tl(TCG_COND_NE, cpu_gpr[rD(ctx->opcode)], t0, zr, + rA(ctx->opcode) ? cpu_gpr[rA(ctx->opcode)] : zr, + cpu_gpr[rB(ctx->opcode)]); + tcg_temp_free(zr); + tcg_temp_free(t0); } /* cmpb: PowerPC 2.05 specification */ -- 2.1.0