qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 05/10] spapr_pci: Define default DMA window size as a macro
Date: Mon, 23 Feb 2015 19:33:55 +1100	[thread overview]
Message-ID: <1424680440-10913-6-git-send-email-aik@ozlabs.ru> (raw)
In-Reply-To: <1424680440-10913-1-git-send-email-aik@ozlabs.ru>

This gets rid of a magic constant describing the default DMA window size
for an emulated PHB.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 hw/ppc/spapr_pci.c          | 6 +++---
 include/hw/pci-host/spapr.h | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 388fd53..130c532 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -641,11 +641,11 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
 static void spapr_phb_finish_realize(sPAPRPHBState *sphb, Error **errp)
 {
     sPAPRTCETable *tcet;
+    uint32_t nb_table;
 
+    nb_table = SPAPR_PCI_DMA32_SIZE >> SPAPR_TCE_PAGE_SHIFT;
     tcet = spapr_tce_new_table(DEVICE(sphb), sphb->dma_liobn,
-                               0,
-                               SPAPR_TCE_PAGE_SHIFT,
-                               0x40000000 >> SPAPR_TCE_PAGE_SHIFT, false);
+                               0, SPAPR_TCE_PAGE_SHIFT, nb_table, false);
     if (!tcet) {
         error_setg(errp, "Unable to create TCE table for %s",
                    sphb->dtbusname);
diff --git a/include/hw/pci-host/spapr.h b/include/hw/pci-host/spapr.h
index d725f0e..718bf59 100644
--- a/include/hw/pci-host/spapr.h
+++ b/include/hw/pci-host/spapr.h
@@ -110,6 +110,8 @@ struct sPAPRPHBVFIOState {
 
 #define SPAPR_PCI_MSI_WINDOW         0x40000000000ULL
 
+#define SPAPR_PCI_DMA32_SIZE         0x40000000
+
 static inline qemu_irq spapr_phb_lsi_qirq(struct sPAPRPHBState *phb, int pin)
 {
     return xics_get_qirq(spapr->icp, phb->lsi_table[pin].irq);
-- 
2.0.0

  parent reply	other threads:[~2015-02-23  8:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23  8:33 [Qemu-devel] [PATCH 00/10] spapr: Small patches to prepare for Dynamic DMA windows Alexey Kardashevskiy
2015-02-23  8:33 ` [Qemu-devel] [PATCH 01/10] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows Alexey Kardashevskiy
2015-02-23  8:33 ` [Qemu-devel] [PATCH 02/10] spapr_iommu: Make H_PUT_TCE_INDIRECT endian-safe Alexey Kardashevskiy
2015-02-23  8:33 ` [Qemu-devel] [PATCH 03/10] spapr_pci: Introduce a liobn number generating macros Alexey Kardashevskiy
2015-02-23  8:33 ` [Qemu-devel] [PATCH 04/10] spapr_vio: " Alexey Kardashevskiy
2015-02-23  8:33 ` Alexey Kardashevskiy [this message]
2015-02-24  5:01   ` [Qemu-devel] [PATCH 05/10] spapr_pci: Define default DMA window size as a macro David Gibson
2015-02-23  8:33 ` [Qemu-devel] [PATCH 06/10] spapr_iommu: Add separate trace points for PCI DMA operations Alexey Kardashevskiy
2015-02-24  5:11   ` David Gibson
2015-02-23  8:33 ` [Qemu-devel] [PATCH 07/10] spapr_pci: Make find_phb()/find_dev() public Alexey Kardashevskiy
2015-02-23  8:33 ` [Qemu-devel] [PATCH 08/10] spapr_iommu: Make spapr_tce_find_by_liobn() public Alexey Kardashevskiy
2015-02-23  8:33 ` [Qemu-devel] [PATCH 09/10] spapr_pci: Rework device-tree rendering Alexey Kardashevskiy
2015-02-24  5:03   ` David Gibson
2015-02-23  8:34 ` [Qemu-devel] [PATCH 10/10] spapr_iommu: Give unique QOM name to TCE table Alexey Kardashevskiy
2015-02-24  5:09   ` David Gibson
2015-03-10  3:51 ` [Qemu-devel] [PATCH 00/10] spapr: Small patches to prepare for Dynamic DMA windows Alexey Kardashevskiy
2015-03-17 11:03   ` Alexey Kardashevskiy
2015-03-24  6:12     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424680440-10913-6-git-send-email-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).