From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mst@redhat.com, armbru@redhat.com,
mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v4 12/17] ide: make more functions static
Date: Mon, 23 Feb 2015 11:18:01 -0500 [thread overview]
Message-ID: <1424708286-16483-13-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1424708286-16483-1-git-send-email-jsnow@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
hw/ide/core.c | 12 ++++++++----
hw/ide/internal.h | 4 ----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index ff28db0..ef52f35 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -561,6 +561,8 @@ static bool ide_sect_range_ok(IDEState *s,
return true;
}
+static void ide_sector_read(IDEState *s);
+
static void ide_sector_read_cb(void *opaque, int ret)
{
IDEState *s = opaque;
@@ -595,7 +597,7 @@ static void ide_sector_read_cb(void *opaque, int ret)
s->io_buffer_offset += 512 * n;
}
-void ide_sector_read(IDEState *s)
+static void ide_sector_read(IDEState *s)
{
int64_t sector_num;
int n;
@@ -682,7 +684,7 @@ static int ide_handle_rw_error(IDEState *s, int error, int op)
return action != BLOCK_ERROR_ACTION_IGNORE;
}
-void ide_dma_cb(void *opaque, int ret)
+static void ide_dma_cb(void *opaque, int ret)
{
IDEState *s = opaque;
int n;
@@ -810,6 +812,8 @@ void ide_start_dma(IDEState *s, BlockCompletionFunc *cb)
}
}
+static void ide_sector_write(IDEState *s);
+
static void ide_sector_write_timer_cb(void *opaque)
{
IDEState *s = opaque;
@@ -869,7 +873,7 @@ static void ide_sector_write_cb(void *opaque, int ret)
}
}
-void ide_sector_write(IDEState *s)
+static void ide_sector_write(IDEState *s)
{
int64_t sector_num;
int n;
@@ -923,7 +927,7 @@ static void ide_flush_cb(void *opaque, int ret)
ide_set_irq(s->bus);
}
-void ide_flush_cache(IDEState *s)
+static void ide_flush_cache(IDEState *s)
{
if (s->blk == NULL) {
ide_flush_cb(s, 0);
diff --git a/hw/ide/internal.h b/hw/ide/internal.h
index 02206a9..0d5f881 100644
--- a/hw/ide/internal.h
+++ b/hw/ide/internal.h
@@ -557,10 +557,6 @@ void ide_init_ioport(IDEBus *bus, ISADevice *isa, int iobase, int iobase2);
void ide_register_restart_cb(IDEBus *bus);
void ide_exec_cmd(IDEBus *bus, uint32_t val);
-void ide_dma_cb(void *opaque, int ret);
-void ide_sector_write(IDEState *s);
-void ide_sector_read(IDEState *s);
-void ide_flush_cache(IDEState *s);
void ide_transfer_start(IDEState *s, uint8_t *buf, int size,
EndTransferFunc *end_transfer_func);
--
1.9.3
next prev parent reply other threads:[~2015-02-23 16:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 16:17 [Qemu-devel] [PATCH v4 00/17] ide: rerror/werror migration fixes for IDE/ISA and AHCI John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 01/17] ide: start extracting ide_restart_dma out of bmdma_restart_dma John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 02/17] ide: prepare to move restart to common code John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 03/17] ide: introduce ide_register_restart_cb John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 04/17] ide: do not use BMDMA in restart callback John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 05/17] ide: pass IDEBus to the restart_cb John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 06/17] ide: move restart callback to common code John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 07/17] ide: remove restart_cb callback John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 08/17] ide: replace set_unit callback with more IDEBus state John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 09/17] ide: place initial state of the current request to IDEBus John Snow
2015-02-23 16:17 ` [Qemu-devel] [PATCH v4 10/17] ide: migrate initial request state via IDEBus John Snow
2015-02-23 16:18 ` [Qemu-devel] [PATCH v4 11/17] ide: commonize io_buffer_index initialization John Snow
2015-02-23 16:18 ` John Snow [this message]
2015-02-23 16:18 ` [Qemu-devel] [PATCH v4 13/17] ide: support PIO restart for the ISA controller John Snow
2015-02-23 16:18 ` [Qemu-devel] [PATCH v4 14/17] ahci: Migrate IDEStatus John Snow
2015-03-13 6:01 ` Amit Shah
2015-03-13 8:21 ` Kevin Wolf
2015-03-13 8:43 ` Amit Shah
2015-02-23 16:18 ` [Qemu-devel] [PATCH v4 15/17] ahci: add support for restarting non-queued commands John Snow
2015-02-23 16:18 ` [Qemu-devel] [PATCH v4 16/17] ahci: Recompute cur_cmd on migrate post load John Snow
2015-02-23 16:18 ` [Qemu-devel] [PATCH v4 17/17] qtest/ide: Test flush / retry for ISA and PCI John Snow
2015-02-25 15:15 ` [Qemu-devel] [PATCH v4 00/17] ide: rerror/werror migration fixes for IDE/ISA and AHCI Stefan Hajnoczi
2015-02-25 20:24 ` John Snow
2015-02-26 11:02 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424708286-16483-13-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).