From: Luiz Capitulino <lcapitulino@redhat.com>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/4] hmp: Fix warning from smatch (wrong argument in function call)
Date: Mon, 23 Feb 2015 11:55:23 -0500 [thread overview]
Message-ID: <1424710526-21474-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1424710526-21474-1-git-send-email-lcapitulino@redhat.com>
From: Stefan Weil <sw@weilnetz.de>
Fix this warning:
hmp.c:414:38: warning: Using plain integer as NULL pointer
qmp_query_block expects a pointer argument, so passing false is wrong.
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
hmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index b47f331..7690323 100644
--- a/hmp.c
+++ b/hmp.c
@@ -411,7 +411,7 @@ void hmp_info_block(Monitor *mon, const QDict *qdict)
/* Print BlockBackend information */
if (!nodes) {
- block_list = qmp_query_block(false);
+ block_list = qmp_query_block(NULL);
} else {
block_list = NULL;
}
--
1.9.3
next prev parent reply other threads:[~2015-02-23 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 16:55 [Qemu-devel] [PULL 0/4] QMP queue Luiz Capitulino
2015-02-23 16:55 ` Luiz Capitulino [this message]
2015-02-23 16:55 ` [Qemu-devel] [PULL 2/4] balloon: Fix typo Luiz Capitulino
2015-02-23 16:55 ` [Qemu-devel] [PULL 3/4] monitor: Fix missing err = NULL in client_migrate_info() Luiz Capitulino
2015-02-23 16:55 ` [Qemu-devel] [PULL 4/4] qapi-types: add C99 index names to arrays Luiz Capitulino
2015-02-26 13:08 ` [Qemu-devel] [PULL 0/4] QMP queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424710526-21474-2-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).