From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PULL 2/7] vl.c: Remove unnecessary zero-initialization of NUMA globals
Date: Mon, 23 Feb 2015 16:29:09 -0300 [thread overview]
Message-ID: <1424719754-2356-3-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1424719754-2356-1-git-send-email-ehabkost@redhat.com>
There's no need to zero-initialize globals, they are automatically
initialized to zero.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
vl.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/vl.c b/vl.c
index eca970e..52a49d9 100644
--- a/vl.c
+++ b/vl.c
@@ -2821,14 +2821,6 @@ int main(int argc, char **argv, char **envp)
cyls = heads = secs = 0;
translation = BIOS_ATA_TRANSLATION_AUTO;
- for (i = 0; i < MAX_NODES; i++) {
- numa_info[i].node_mem = 0;
- numa_info[i].present = false;
- bitmap_zero(numa_info[i].node_cpu, MAX_CPUMASK_BITS);
- }
-
- nb_numa_nodes = 0;
- max_numa_nodeid = 0;
nb_nics = 0;
bdrv_init_with_whitelist();
--
2.1.0
next prev parent reply other threads:[~2015-02-23 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 19:29 [Qemu-devel] [PULL 0/7] NUMA queue Eduardo Habkost
2015-02-23 19:29 ` [Qemu-devel] [PULL 1/7] numa: Move NUMA declarations from sysemu.h to numa.h Eduardo Habkost
2015-02-23 19:29 ` Eduardo Habkost [this message]
2015-02-23 19:29 ` [Qemu-devel] [PULL 3/7] numa: Move NUMA globals to numa.c Eduardo Habkost
2015-02-23 19:29 ` [Qemu-devel] [PULL 4/7] numa: Make max_numa_nodeid static Eduardo Habkost
2015-02-23 19:29 ` [Qemu-devel] [PULL 5/7] numa: Move QemuOpts parsing to set_numa_nodes() Eduardo Habkost
2015-02-23 19:29 ` [Qemu-devel] [PULL 6/7] numa: Rename option parsing functions Eduardo Habkost
2015-02-23 19:29 ` [Qemu-devel] [PULL 7/7] numa: Rename set_numa_modes() to numa_post_machine_init() Eduardo Habkost
2015-03-02 13:20 ` [Qemu-devel] [PULL 0/7] NUMA queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424719754-2356-3-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).