From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQfbO-0006PI-Rb for qemu-devel@nongnu.org; Wed, 25 Feb 2015 12:18:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQfbL-0001qI-KV for qemu-devel@nongnu.org; Wed, 25 Feb 2015 12:18:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQfbL-0001qC-DQ for qemu-devel@nongnu.org; Wed, 25 Feb 2015 12:18:23 -0500 From: John Snow Date: Wed, 25 Feb 2015 11:34:56 -0500 Message-Id: <1424882098-10674-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1424882098-10674-1-git-send-email-jsnow@redhat.com> References: <1424882098-10674-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [RFC 1/3] qtest: allow arbitrarily long sends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marc.mari.barcelo@gmail.com, pbonzini@redhat.com, John Snow , afaerber@suse.de, stefanha@redhat.com qtest currently has a static buffer of size 1024 that if we overflow, ignores the additional data silently which leads to hangs or stream failures. Use glib's string facilities to allow arbitrarily long data. Signed-off-by: John Snow --- qtest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qtest.c b/qtest.c index 2bca04e..242dcc0 100644 --- a/qtest.c +++ b/qtest.c @@ -186,11 +186,12 @@ static void GCC_FMT_ATTR(2, 3) qtest_send(CharDriverState *chr, const char *fmt, ...) { va_list ap; - char buffer[1024]; size_t len; + gchar *buffer; va_start(ap, fmt); - len = vsnprintf(buffer, sizeof(buffer), fmt, ap); + buffer = g_strdup_vprintf(fmt, ap); + len = strlen(buffer); va_end(ap); qemu_chr_fe_write_all(chr, (uint8_t *)buffer, len); -- 1.9.3