From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQfD3-0000fX-Lm for qemu-devel@nongnu.org; Wed, 25 Feb 2015 11:53:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQfD2-0001IY-6s for qemu-devel@nongnu.org; Wed, 25 Feb 2015 11:53:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQfD1-0001II-WF for qemu-devel@nongnu.org; Wed, 25 Feb 2015 11:53:16 -0500 From: "Dr. David Alan Gilbert (git)" Date: Wed, 25 Feb 2015 16:51:47 +0000 Message-Id: <1424883128-9841-25-git-send-email-dgilbert@redhat.com> In-Reply-To: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH v5 24/45] MIG_STATE_POSTCOPY_ACTIVE: Add new migration state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com, david@gibson.dropbear.id.au From: "Dr. David Alan Gilbert" 'MIG_STATE_POSTCOPY_ACTIVE' is entered after migrate_start_postcopy 'migration_postcopy_phase' is provided for other sections to know if they're in postcopy. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 2 ++ migration/migration.c | 58 ++++++++++++++++++++++++++++++++++++++----- trace-events | 1 + 3 files changed, 55 insertions(+), 6 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index 293c83e..b44b9b2 100644 --- a/include/migration/migration.h +++ b/include/migration/migration.h @@ -151,6 +151,8 @@ MigrationState *migrate_init(const MigrationParams *params); bool migration_in_setup(MigrationState *); bool migration_has_finished(MigrationState *); bool migration_has_failed(MigrationState *); +/* True if outgoing migration has entered postcopy phase */ +bool migration_postcopy_phase(MigrationState *); MigrationState *migrate_get_current(void); uint64_t ram_bytes_remaining(void); diff --git a/migration/migration.c b/migration/migration.c index 43ca656..6b20b56 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -26,13 +26,14 @@ #include "qmp-commands.h" #include "trace.h" -enum { +enum MigrationPhase { MIG_STATE_ERROR = -1, MIG_STATE_NONE, MIG_STATE_SETUP, MIG_STATE_CANCELLING, MIG_STATE_CANCELLED, MIG_STATE_ACTIVE, + MIG_STATE_POSTCOPY_ACTIVE, MIG_STATE_COMPLETED, }; @@ -247,6 +248,7 @@ static bool migration_already_active(MigrationState *ms) { switch (ms->state) { case MIG_STATE_ACTIVE: + case MIG_STATE_POSTCOPY_ACTIVE: case MIG_STATE_SETUP: return true; @@ -319,6 +321,40 @@ MigrationInfo *qmp_query_migrate(Error **errp) get_xbzrle_cache_stats(info); break; + case MIG_STATE_POSTCOPY_ACTIVE: + /* Mostly the same as active; TODO add some postcopy stats */ + info->has_status = true; + info->status = g_strdup("postcopy-active"); + info->has_total_time = true; + info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + - s->total_time; + info->has_expected_downtime = true; + info->expected_downtime = s->expected_downtime; + info->has_setup_time = true; + info->setup_time = s->setup_time; + + info->has_ram = true; + info->ram = g_malloc0(sizeof(*info->ram)); + info->ram->transferred = ram_bytes_transferred(); + info->ram->remaining = ram_bytes_remaining(); + info->ram->total = ram_bytes_total(); + info->ram->duplicate = dup_mig_pages_transferred(); + info->ram->skipped = skipped_mig_pages_transferred(); + info->ram->normal = norm_mig_pages_transferred(); + info->ram->normal_bytes = norm_mig_bytes_transferred(); + info->ram->dirty_pages_rate = s->dirty_pages_rate; + info->ram->mbps = s->mbps; + + if (blk_mig_active()) { + info->has_disk = true; + info->disk = g_malloc0(sizeof(*info->disk)); + info->disk->transferred = blk_mig_bytes_transferred(); + info->disk->remaining = blk_mig_bytes_remaining(); + info->disk->total = blk_mig_bytes_total(); + } + + get_xbzrle_cache_stats(info); + break; case MIG_STATE_COMPLETED: get_xbzrle_cache_stats(info); @@ -362,7 +398,7 @@ void qmp_migrate_set_capabilities(MigrationCapabilityStatusList *params, MigrationState *s = migrate_get_current(); MigrationCapabilityStatusList *cap; - if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP) { + if (migration_already_active(s)) { error_set(errp, QERR_MIGRATION_ACTIVE); return; } @@ -437,7 +473,8 @@ static void migrate_fd_cleanup(void *opaque) s->file = NULL; } - assert(s->state != MIG_STATE_ACTIVE); + assert((s->state != MIG_STATE_ACTIVE) && + (s->state != MIG_STATE_POSTCOPY_ACTIVE)); if (s->state != MIG_STATE_COMPLETED) { qemu_savevm_state_cancel(); @@ -471,7 +508,8 @@ static void migrate_fd_cancel(MigrationState *s) do { old_state = s->state; - if (old_state != MIG_STATE_SETUP && old_state != MIG_STATE_ACTIVE) { + if (old_state != MIG_STATE_SETUP && old_state != MIG_STATE_ACTIVE && + old_state != MIG_STATE_POSTCOPY_ACTIVE) { break; } migrate_set_state(s, old_state, MIG_STATE_CANCELLING); @@ -515,6 +553,11 @@ bool migration_has_failed(MigrationState *s) s->state == MIG_STATE_ERROR); } +bool migration_postcopy_phase(MigrationState *s) +{ + return (s->state == MIG_STATE_POSTCOPY_ACTIVE); +} + MigrationState *migrate_init(const MigrationParams *params) { MigrationState *s = migrate_get_current(); @@ -563,7 +606,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, params.blk = has_blk && blk; params.shared = has_inc && inc; - if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP || + if (migration_already_active(s) || s->state == MIG_STATE_CANCELLING) { error_set(errp, QERR_MIGRATION_ACTIVE); return; @@ -885,7 +928,10 @@ static void *migration_thread(void *opaque) s->setup_time = qemu_clock_get_ms(QEMU_CLOCK_HOST) - setup_start; migrate_set_state(s, MIG_STATE_SETUP, MIG_STATE_ACTIVE); - while (s->state == MIG_STATE_ACTIVE) { + trace_migration_thread_setup_complete(); + + while (s->state == MIG_STATE_ACTIVE || + s->state == MIG_STATE_POSTCOPY_ACTIVE) { int64_t current_time; uint64_t pending_size; diff --git a/trace-events b/trace-events index 83312b6..941976a 100644 --- a/trace-events +++ b/trace-events @@ -1402,6 +1402,7 @@ migrate_fd_error(void) "" migrate_fd_cancel(void) "" migrate_pending(uint64_t size, uint64_t max, uint64_t post, uint64_t nonpost) "pending size %" PRIu64 " max %" PRIu64 " (post=%" PRIu64 " nonpost=%" PRIu64 ")" migrate_send_rp_message(int cmd, uint16_t len) "cmd=%d, len=%d" +migration_thread_setup_complete(void) "" open_outgoing_return_path(void) "" open_outgoing_return_path_continue(void) "" source_return_path_thread_bad_end(void) "" -- 2.1.0