qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, John Snow <jsnow@redhat.com>,
	armbru@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 1/8] libqos/ahci: Zero-fill AHCI headers
Date: Wed, 25 Feb 2015 18:06:35 -0500	[thread overview]
Message-ID: <1424905602-24715-2-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1424905602-24715-1-git-send-email-jsnow@redhat.com>

Even though it's just the reserved space, make sure they're zeroes.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 tests/libqos/ahci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index a6105c7..9dc505c 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -487,7 +487,7 @@ void ahci_get_command_header(AHCIQState *ahci, uint8_t port,
 void ahci_set_command_header(AHCIQState *ahci, uint8_t port,
                              uint8_t slot, AHCICommandHeader *cmd)
 {
-    AHCICommandHeader tmp;
+    AHCICommandHeader tmp = { .flags = 0 };
     uint64_t ba = ahci->port[port].clb;
     ba += slot * sizeof(AHCICommandHeader);
 
-- 
1.9.3

  reply	other threads:[~2015-02-25 23:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 23:06 [Qemu-devel] [PATCH v2 0/8] ahci: add more IO tests John Snow
2015-02-25 23:06 ` John Snow [this message]
2015-02-25 23:06 ` [Qemu-devel] [PATCH v2 2/8] qtest/ahci: Add a macro bootup routine John Snow
2015-02-25 23:06 ` [Qemu-devel] [PATCH v2 3/8] libqos/ahci: add ahci command helpers John Snow
2015-02-25 23:06 ` [Qemu-devel] [PATCH v2 4/8] qtest/ahci: Add DMA test variants John Snow
2015-02-25 23:06 ` [Qemu-devel] [PATCH v2 5/8] qtest/ahci: Add PIO and LBA48 tests John Snow
2015-02-25 23:06 ` [Qemu-devel] [PATCH v2 6/8] qtest/ahci: add fragmented dma test John Snow
2015-02-25 23:06 ` [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test John Snow
2015-03-09 14:27   ` Kevin Wolf
2015-03-09 16:03     ` John Snow
2015-03-09 16:27       ` Kevin Wolf
2015-03-09 16:35         ` John Snow
2015-03-09 16:33       ` Markus Armbruster
2015-03-09 20:34     ` John Snow
2015-03-10  8:16       ` Kevin Wolf
2015-02-25 23:06 ` [Qemu-devel] [PATCH v2 8/8] qtest/ahci: test different disk sectors John Snow
2015-02-26 15:12 ` [Qemu-devel] [PATCH v2 0/8] ahci: add more IO tests Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424905602-24715-2-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).