From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQzpz-0004Dt-40 for qemu-devel@nongnu.org; Thu, 26 Feb 2015 09:54:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQzpx-00005A-WC for qemu-devel@nongnu.org; Thu, 26 Feb 2015 09:54:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQzpx-00004w-PK for qemu-devel@nongnu.org; Thu, 26 Feb 2015 09:54:49 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1QEsni0025875 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 26 Feb 2015 09:54:49 -0500 From: "Dr. David Alan Gilbert (git)" Date: Thu, 26 Feb 2015 14:54:41 +0000 Message-Id: <1424962481-16439-4-git-send-email-dgilbert@redhat.com> In-Reply-To: <1424962481-16439-1-git-send-email-dgilbert@redhat.com> References: <1424962481-16439-1-git-send-email-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] migrate_incoming: Cleanup/clarify error messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, armbru@redhat.com, quintela@redhat.com From: "Dr. David Alan Gilbert" Create a separate error for the case where migrate_incoming is used after a succesful migrate_incoming. Reword the error in the case where '-incoming defer' is missing to omit the command name so it's right for both hmp and qmp. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 2c805f1..e6ac3de 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -435,11 +435,15 @@ void migrate_del_blocker(Error *reason) void qmp_migrate_incoming(const char *uri, Error **errp) { Error *local_err = NULL; + static bool once = true; if (!deferred_incoming) { - error_setg(errp, "'-incoming defer' is required for migrate_incoming"); + error_setg(errp, "For use with '-incoming defer'"); return; } + if (!once) { + error_setg(errp, "The incoming migration has already been started"); + } qemu_start_incoming_migration(uri, &local_err); @@ -448,7 +452,7 @@ void qmp_migrate_incoming(const char *uri, Error **errp) return; } - deferred_incoming = false; + once = false; } void qmp_migrate(const char *uri, bool has_blk, bool blk, -- 2.1.0