From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR8CA-0007I1-VO for qemu-devel@nongnu.org; Thu, 26 Feb 2015 18:50:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YR8C9-00053F-Dp for qemu-devel@nongnu.org; Thu, 26 Feb 2015 18:50:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR8C9-00052y-21 for qemu-devel@nongnu.org; Thu, 26 Feb 2015 18:50:17 -0500 From: John Snow Date: Thu, 26 Feb 2015 18:50:05 -0500 Message-Id: <1424994606-32490-9-git-send-email-jsnow@redhat.com> In-Reply-To: <1424994606-32490-1-git-send-email-jsnow@redhat.com> References: <1424994606-32490-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH v2 8/9] qtest/ahci: add halted dma test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, marc.mari.barcelo@gmail.com, mst@redhat.com, armbru@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, John Snow If we're going to test the migration of halted DMA jobs, we should probably check to make sure we can resume them locally as a first step. Signed-off-by: John Snow --- tests/ahci-test.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 3dbcc2b..792b722 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -1133,6 +1133,65 @@ static void test_migrate_dma(void) } /** + * DMA Error Test + * + * Simulate an error on first write, Try to write a pattern, + * Confirm the VM has stopped, resume the VM, verify command + * has completed, then read back the data and verify. + */ +static void test_halted_dma(void) +{ + AHCIQState *ahci; + uint8_t port; + size_t bufsize = 4096; + unsigned char *tx = g_malloc(bufsize); + unsigned char *rx = g_malloc0(bufsize); + unsigned i; + uint64_t ptr; + AHCICommand *cmd; + + prepare_blkdebug_script(debug_path, "write_aio"); + + ahci = ahci_boot_and_enable("-drive file=blkdebug:%s:%s,if=none,id=drive0," + "format=qcow2,cache=writeback," + "rerror=stop,werror=stop " + "-M q35 " + "-device ide-hd,drive=drive0 ", + debug_path, + tmp_path); + + /* Initialize and prepare */ + port = ahci_port_select(ahci); + ahci_port_clear(ahci, port); + + for (i = 0; i < bufsize; i++) { + tx[i] = (bufsize - i); + } + + /* create DMA source buffer and write pattern */ + ptr = ahci_alloc(ahci, bufsize); + g_assert(ptr); + memwrite(ptr, tx, bufsize); + + /* Attempt to write (and fail) */ + cmd = ahci_guest_io_halt(ahci, port, CMD_WRITE_DMA, + ptr, bufsize, 0); + + /* Attempt to resume the command */ + ahci_guest_io_resume(ahci, cmd); + ahci_free(ahci, ptr); + + /* Read back and verify */ + ahci_io(ahci, port, CMD_READ_DMA, rx, bufsize, 0); + g_assert_cmphex(memcmp(tx, rx, bufsize), ==, 0); + + /* Cleanup and go home */ + ahci_shutdown(ahci); + g_free(rx); + g_free(tx); +} + +/** * Migration test: Try to flush, migrate, then resume. */ static void test_flush_migrate(void) @@ -1433,6 +1492,7 @@ int main(int argc, char **argv) qtest_add_func("/ahci/migrate/sanity", test_migrate_sanity); qtest_add_func("/ahci/migrate/dma", test_migrate_dma); + qtest_add_func("/ahci/io/dma/lba28/retry", test_halted_dma); ret = g_test_run(); -- 1.9.3