* [Qemu-devel] [PATCH] spapr: fix potential segfault due to uninitialized Error*
@ 2015-02-27 1:14 Michael Roth
2015-02-27 7:31 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Michael Roth @ 2015-02-27 1:14 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-ppc, agraf, armbru
Introduced by 361f93e.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index e1e66f2..2152704 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -111,7 +111,7 @@ sPAPREnvironment *spapr;
static XICSState *try_create_xics(const char *type, int nr_servers,
int nr_irqs, Error **errp)
{
- Error *err;
+ Error *err = NULL;
DeviceState *dev;
dev = qdev_create(NULL, type);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr: fix potential segfault due to uninitialized Error*
2015-02-27 1:14 [Qemu-devel] [PATCH] spapr: fix potential segfault due to uninitialized Error* Michael Roth
@ 2015-02-27 7:31 ` Markus Armbruster
2015-02-27 15:26 ` Alexander Graf
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2015-02-27 7:31 UTC (permalink / raw)
To: Michael Roth; +Cc: qemu-ppc, qemu-devel, agraf
Michael Roth <mdroth@linux.vnet.ibm.com> writes:
> Introduced by 361f93e.
>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Since it hasn't been merged into master: can we still squash this into
my broken commit?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr: fix potential segfault due to uninitialized Error*
2015-02-27 7:31 ` Markus Armbruster
@ 2015-02-27 15:26 ` Alexander Graf
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2015-02-27 15:26 UTC (permalink / raw)
To: Markus Armbruster, Michael Roth; +Cc: qemu-ppc, qemu-devel
On 27.02.15 08:31, Markus Armbruster wrote:
> Michael Roth <mdroth@linux.vnet.ibm.com> writes:
>
>> Introduced by 361f93e.
>>
>> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> Since it hasn't been merged into master: can we still squash this into
> my broken commit?
>
Thanks, squashed into the broken commit.
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-27 15:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 1:14 [Qemu-devel] [PATCH] spapr: fix potential segfault due to uninitialized Error* Michael Roth
2015-02-27 7:31 ` Markus Armbruster
2015-02-27 15:26 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).