From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRHMj-0000V0-Hj for qemu-devel@nongnu.org; Fri, 27 Feb 2015 04:37:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRHMf-0001yb-Kv for qemu-devel@nongnu.org; Fri, 27 Feb 2015 04:37:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRHMf-0001xt-CE for qemu-devel@nongnu.org; Fri, 27 Feb 2015 04:37:45 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1R9biGh000678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 27 Feb 2015 04:37:44 -0500 Message-ID: <1425029862.20883.26.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 27 Feb 2015 10:37:42 +0100 In-Reply-To: <54EE2AD2.4000202@redhat.com> References: <1424687012-18524-1-git-send-email-kraxel@redhat.com> <1424687012-18524-6-git-send-email-kraxel@redhat.com> <54EE2AD2.4000202@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH 05/15] virtio-gpu/2d: add hardware spec include file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Dave Airlie , qemu-devel@nongnu.org On Mi, 2015-02-25 at 15:04 -0500, Max Reitz wrote: > On 2015-02-23 at 05:23, Gerd Hoffmann wrote: > > This patch adds the header file with structs and defines for > > the virtio based gpu device. Covers 2d operations only. > > > > Written by Dave Airlie and Gerd Hoffmann. > > > > Signed-off-by: Dave Airlie > > Signed-off-by: Gerd Hoffmann > > --- > > include/hw/virtio/virtgpu_hw.h | 203 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 203 insertions(+) > > create mode 100644 include/hw/virtio/virtgpu_hw.h > > > > diff --git a/include/hw/virtio/virtgpu_hw.h b/include/hw/virtio/virtgpu_hw.h > > new file mode 100644 > > index 0000000..d6641e8 > > --- /dev/null > > +++ b/include/hw/virtio/virtgpu_hw.h > > @@ -0,0 +1,203 @@ > > +/* > > + * Virtio GPU Device > > + * > > + * Copyright Red Hat, Inc. 2013-2014 > > Hm... Well, if there haven't been any changes since 2014... The header files hasn't seen any 2015 changes indeed ;) > > + * 3. Neither the name of IBM nor the names of its contributors > > Is the "IBM" intended? Looks like cut+paste from virtio_ring.h ... 'IBM' probably comes from rusty being employed by IBM. > > +struct virtio_gpu_ctrl_hdr { > > + uint32_t type; > > + uint32_t flags; > > + uint64_t fence_id; > > + uint32_t ctx_id; > > + uint32_t padding; > > +}; > > Shouldn't all these structures be QEMU_PACKED? In practice, it won't > matter (I hope!), but if you're relying on it... It should not indeed, I carefully checked we don't have any funky stuff in there, like unaligned 64bit fields which have different packing in i686 and x86_64. Also the header files is shared between linux and qemu, so adding QEMU_PACKED there is a bit difficult. cheers, Gerd