From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YRLwj-0007Es-Si
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:31:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YRLwd-00049Q-Oj
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:31:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45136)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YRLwd-00048C-Hj
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:31:11 -0500
Message-ID: <1425047464.20883.60.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 27 Feb 2015 15:31:04 +0100
In-Reply-To: <54F07D31.2000100@redhat.com>
References: <1424687012-18524-1-git-send-email-kraxel@redhat.com>
	<1424687012-18524-7-git-send-email-kraxel@redhat.com>
	<54EF44F1.1090507@redhat.com>
	<1425035430.20883.44.camel@nilsson.home.kraxel.org>
	<54F07D31.2000100@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu
 core code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>

> >>> +    if (t2d.offset || t2d.r.x || t2d.r.y ||
> >>> +        t2d.r.width != pixman_image_get_width(res->image)) {

> >> Will this work with stride != t2d.r.width * bpp?
> > Those cases should take the if branch above and loop over all lines to
> > handle it correctly.
> 
> Exactly, but it looks like to me that it doesn't (at least not always).

Ah, you mean we should better check something like

  t2d.r.width * bpp != pixman_image_get_stride() ?

That should check exactly the same thing as we never create resources
with extra padding where width * bpp != stride.

cheers,
  Gerd