qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com,
	dgilbert@redhat.com, vsementsov@parallels.com,
	stefanha@redhat.com, den@openvz.org, amit.shah@redhat.com,
	pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH RFC v4 03/13] block: tiny refactoring: minimize hbitmap_(set/reset) usage
Date: Fri, 27 Feb 2015 20:24:41 +0300	[thread overview]
Message-ID: <1425057891-29848-4-git-send-email-vsementsov@parallels.com> (raw)
In-Reply-To: <1425057891-29848-1-git-send-email-vsementsov@parallels.com>

Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
---
 block.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/block.c b/block.c
index e95a5ae..a127fd2 100644
--- a/block.c
+++ b/block.c
@@ -5670,8 +5670,7 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap,
 
 void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap)
 {
-    assert(bdrv_dirty_bitmap_enabled(bitmap));
-    hbitmap_reset(bitmap->bitmap, 0, bitmap->size);
+    bdrv_reset_dirty_bitmap(bitmap, 0, bitmap->size);
 }
 
 const char *bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap)
@@ -5718,7 +5717,7 @@ static void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector,
         if (!bdrv_dirty_bitmap_enabled(bitmap)) {
             continue;
         }
-        hbitmap_set(bitmap->bitmap, cur_sector, nr_sectors);
+        bdrv_set_dirty_bitmap(bitmap, cur_sector, nr_sectors);
     }
 }
 
@@ -5730,7 +5729,7 @@ static void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector,
         if (!bdrv_dirty_bitmap_enabled(bitmap)) {
             continue;
         }
-        hbitmap_reset(bitmap->bitmap, cur_sector, nr_sectors);
+        bdrv_reset_dirty_bitmap(bitmap, cur_sector, nr_sectors);
     }
 }
 
-- 
1.9.1

  parent reply	other threads:[~2015-02-27 18:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 17:24 [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 01/13] hbitmap: serialization Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 02/13] block: BdrvDirtyBitmap serialization interface Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` Vladimir Sementsov-Ogievskiy [this message]
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 04/13] block: add meta bitmaps Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 05/13] block: add bdrv_next_dirty_bitmap() Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 06/13] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2015-02-27 18:29   ` Eric Blake
2015-03-02 10:02     ` Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 07/13] migration: add migration/block-dirty-bitmap.c Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 08/13] iotests: maintain several vms in test Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 09/13] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 10/13] iotests: add event_wait " Vladimir Sementsov-Ogievskiy
2015-05-07 19:45   ` John Snow
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 11/13] qapi: add md5 checksum of last dirty bitmap level to query-block Vladimir Sementsov-Ogievskiy
2015-02-27 18:32   ` Eric Blake
2015-02-27 20:08     ` John Snow
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 12/13] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 13/13] migration/qemu-file: make functions qemu_(get/put)_string public Vladimir Sementsov-Ogievskiy
2015-02-27 20:13 ` [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration John Snow
2015-03-02 10:30   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425057891-29848-4-git-send-email-vsementsov@parallels.com \
    --to=vsementsov@parallels.com \
    --cc=amit.shah@redhat.com \
    --cc=den@openvz.org \
    --cc=dgilbert@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).