From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com,
dgilbert@redhat.com, vsementsov@parallels.com,
stefanha@redhat.com, den@openvz.org, amit.shah@redhat.com,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH RFC v4 08/13] iotests: maintain several vms in test
Date: Fri, 27 Feb 2015 20:24:46 +0300 [thread overview]
Message-ID: <1425057891-29848-9-git-send-email-vsementsov@parallels.com> (raw)
In-Reply-To: <1425057891-29848-1-git-send-email-vsementsov@parallels.com>
The only problem with it is the same qmp socket name (which is
vm._monitor_path) for all vms. And because of this second vm couldn't be
lauched (vm.launch() fails because of socket is already in use).
This patch adds a number of vm into vm._monitor_path
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
---
tests/qemu-iotests/iotests.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index cf5faac..fa756b4 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -77,16 +77,18 @@ def create_image(name, size):
class VM(object):
'''A QEMU VM'''
+ nb_vms = 0
def __init__(self):
- self._monitor_path = os.path.join(test_dir, 'qemu-mon.%d' % os.getpid())
- self._qemu_log_path = os.path.join(test_dir, 'qemu-log.%d' % os.getpid())
+ self._monitor_path = os.path.join(test_dir, 'qemu-mon.%d.%d' % (os.getpid(), VM.nb_vms))
+ self._qemu_log_path = os.path.join(test_dir, 'qemu-log.%d.%d' % (os.getpid(), VM.nb_vms))
self._args = qemu_args + ['-chardev',
'socket,id=mon,path=' + self._monitor_path,
'-mon', 'chardev=mon,mode=control',
'-qtest', 'stdio', '-machine', 'accel=qtest',
'-display', 'none', '-vga', 'none']
self._num_drives = 0
+ VM.nb_vms += 1
# This can be used to add an unused monitor instance.
def add_monitor_telnet(self, ip, port):
--
1.9.1
next prev parent reply other threads:[~2015-02-27 18:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 17:24 [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 01/13] hbitmap: serialization Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 02/13] block: BdrvDirtyBitmap serialization interface Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 03/13] block: tiny refactoring: minimize hbitmap_(set/reset) usage Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 04/13] block: add meta bitmaps Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 05/13] block: add bdrv_next_dirty_bitmap() Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 06/13] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2015-02-27 18:29 ` Eric Blake
2015-03-02 10:02 ` Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 07/13] migration: add migration/block-dirty-bitmap.c Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` Vladimir Sementsov-Ogievskiy [this message]
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 09/13] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 10/13] iotests: add event_wait " Vladimir Sementsov-Ogievskiy
2015-05-07 19:45 ` John Snow
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 11/13] qapi: add md5 checksum of last dirty bitmap level to query-block Vladimir Sementsov-Ogievskiy
2015-02-27 18:32 ` Eric Blake
2015-02-27 20:08 ` John Snow
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 12/13] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2015-02-27 17:24 ` [Qemu-devel] [PATCH RFC v4 13/13] migration/qemu-file: make functions qemu_(get/put)_string public Vladimir Sementsov-Ogievskiy
2015-02-27 20:13 ` [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration John Snow
2015-03-02 10:30 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425057891-29848-9-git-send-email-vsementsov@parallels.com \
--to=vsementsov@parallels.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).