From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Brad Campbell <lists2009@fnarfbargle.com>
Subject: [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for secondary qxl devices
Date: Mon, 2 Mar 2015 17:09:13 +0100 [thread overview]
Message-ID: <1425312553-19877-1-git-send-email-kraxel@redhat.com> (raw)
Commit 3dcadce5076d4b42fa395c39662d65e050b77784 added three
update_displaychangelistener call sites:
Two for primary qxl cards, when entering/leaving vga mode, which are
correct.
One for secondary qxl cards, which is wrong because we don't register
a displaychangelistener in the first place for secondary cards.
Remove it.
Reported-by: Brad Campbell <lists2009@fnarfbargle.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/qxl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 94ff52a..762f75d 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -1147,7 +1147,6 @@ static void qxl_soft_reset(PCIQXLDevice *d)
qxl_enter_vga_mode(d);
} else {
d->mode = QXL_MODE_UNDEFINED;
- update_displaychangelistener(&d->ssd.dcl, GUI_REFRESH_INTERVAL_IDLE);
}
}
--
1.8.3.1
next reply other threads:[~2015-03-02 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 16:09 Gerd Hoffmann [this message]
2015-03-03 1:36 ` [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for secondary qxl devices Brad Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425312553-19877-1-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=lists2009@fnarfbargle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).