From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YShzZ-0006b3-OX for qemu-devel@nongnu.org; Tue, 03 Mar 2015 03:15:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YShzU-0006vv-GN for qemu-devel@nongnu.org; Tue, 03 Mar 2015 03:15:49 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:60290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YShzU-0006vf-5n for qemu-devel@nongnu.org; Tue, 03 Mar 2015 03:15:44 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Mar 2015 08:15:42 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id BA3032190046 for ; Tue, 3 Mar 2015 08:15:32 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t238FefM8192444 for ; Tue, 3 Mar 2015 08:15:40 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t238Fd8L020571 for ; Tue, 3 Mar 2015 01:15:40 -0700 From: Christian Borntraeger Date: Tue, 3 Mar 2015 09:15:26 +0100 Message-Id: <1425370526-15215-1-git-send-email-borntraeger@de.ibm.com> In-Reply-To: <20150302092822.GB4443@noname.redhat.com> References: <20150302092822.GB4443@noname.redhat.com> Subject: [Qemu-devel] [PATCH] Add testcase for scsi-hd devices without drive property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: thuth@linux.vnet.ibm.com, Christian Borntraeger , qemu-devel@nongnu.org, tumanova@linux.vnet.ibm.com, armbru@redhat.com, mihajlov@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com, mreitz@redhat.com CC: Max Reitz Suggested-by: Kevin Wolf Signed-off-by: Christian Borntraeger --- tests/qemu-iotests/051 | 9 +++++++++ tests/qemu-iotests/051.out | 8 ++++++++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index 11c858f..1eec350 100755 --- a/tests/qemu-iotests/051 +++ b/tests/qemu-iotests/051 @@ -95,6 +95,15 @@ run_qemu -drive file="$TEST_IMG",driver=foo run_qemu -drive file="$TEST_IMG",driver=raw,format=qcow2 echo +echo === Device without drive === +echo + +# virtio-scsi-pci, virtio-scsi-ccw, virtio-scsi-s390... +VIRTSCSIDEV=`${QEMU} -device help 2>&1 | grep -v virtio-scsi-device | grep -m 1 virtio-scsi | cut -d \" -f 2` + +run_qemu -device ${VIRTSCSIDEV} -device scsi-hd + +echo echo === Overriding backing file === echo diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out index f497c57..e8e3258 100644 --- a/tests/qemu-iotests/051.out +++ b/tests/qemu-iotests/051.out @@ -44,6 +44,14 @@ Testing: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2 QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2: could not open disk image TEST_DIR/t.qcow2: Driver specified twice +=== Device without drive === + +Testing: -device virtio-scsi-pci -device scsi-hd +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) QEMU_PROG: -device scsi-hd: drive property not set +QEMU_PROG: -device scsi-hd: Device 'scsi-hd' could not be initialized + + === Overriding backing file === Testing: -drive file=TEST_DIR/t.qcow2,driver=qcow2,backing.file.filename=TEST_DIR/t.qcow2.orig -nodefaults -- 1.7.1