* [Qemu-devel] [PATCH] hmp: info spice: take out webdav
@ 2015-03-03 8:31 Gerd Hoffmann
2015-03-03 15:26 ` Cole Robinson
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2015-03-03 8:31 UTC (permalink / raw)
To: qemu-devel; +Cc: spice-devel, Luiz Capitulino, Gerd Hoffmann, crobinso
Obvious suggestion for the next spice-protocol
release: Add some way to #ifdef new stuff.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hmp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hmp.c b/hmp.c
index eacfb1b..71c28bc 100644
--- a/hmp.c
+++ b/hmp.c
@@ -561,7 +561,12 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict)
[SPICE_CHANNEL_SMARTCARD] = "smartcard",
[SPICE_CHANNEL_USBREDIR] = "usbredir",
[SPICE_CHANNEL_PORT] = "port",
+#if 0
+ /* minimum spice-protocol is 0.12.3, webdav was added in 0.12.7,
+ * no easy way to #ifdef (SPICE_CHANNEL_* is a enum). Disable
+ * as quick fix for build failures with older versions. */
[SPICE_CHANNEL_WEBDAV] = "webdav",
+#endif
};
info = qmp_query_spice(NULL);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] hmp: info spice: take out webdav
2015-03-03 8:31 [Qemu-devel] [PATCH] hmp: info spice: take out webdav Gerd Hoffmann
@ 2015-03-03 15:26 ` Cole Robinson
0 siblings, 0 replies; 2+ messages in thread
From: Cole Robinson @ 2015-03-03 15:26 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: spice-devel, Luiz Capitulino
On 03/03/2015 03:31 AM, Gerd Hoffmann wrote:
> Obvious suggestion for the next spice-protocol
> release: Add some way to #ifdef new stuff.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hmp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hmp.c b/hmp.c
> index eacfb1b..71c28bc 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -561,7 +561,12 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict)
> [SPICE_CHANNEL_SMARTCARD] = "smartcard",
> [SPICE_CHANNEL_USBREDIR] = "usbredir",
> [SPICE_CHANNEL_PORT] = "port",
> +#if 0
> + /* minimum spice-protocol is 0.12.3, webdav was added in 0.12.7,
> + * no easy way to #ifdef (SPICE_CHANNEL_* is a enum). Disable
> + * as quick fix for build failures with older versions. */
> [SPICE_CHANNEL_WEBDAV] = "webdav",
> +#endif
> };
>
> info = qmp_query_spice(NULL);
>
Hmm sorry about that.
Reviewed-by: Cole Robinson <crobinso@redhat.com>
- Cole
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-03 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-03 8:31 [Qemu-devel] [PATCH] hmp: info spice: take out webdav Gerd Hoffmann
2015-03-03 15:26 ` Cole Robinson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).