qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, carnold@suse.com, famz@redhat.com,
	jcody@redhat.com, Peter Lieven <pl@kamp.de>,
	mreitz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 4/5] block/vpc: rename footer->size -> footer->current_size
Date: Tue,  3 Mar 2015 11:41:55 +0100	[thread overview]
Message-ID: <1425379316-19639-5-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1425379316-19639-1-git-send-email-pl@kamp.de>

the field is named current size in the spec. Name it accordingly.

Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 block/vpc.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/block/vpc.c b/block/vpc.c
index 7e99a69..226be02 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -66,7 +66,7 @@ typedef struct vhd_footer {
     char        creator_os[4]; // "Wi2k"
 
     uint64_t    orig_size;
-    uint64_t    size;
+    uint64_t    current_size;
 
     uint16_t    cyls;
     uint8_t     heads;
@@ -218,9 +218,10 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,
 
     /* Images that have exactly the maximum geometry are probably bigger and
      * would be truncated if we adhered to the geometry for them. Rely on
-     * footer->size for them. */
+     * footer->current_size for them. */
     if (bs->total_sectors == VHD_MAX_GEOMETRY) {
-        bs->total_sectors = be64_to_cpu(footer->size) / BDRV_SECTOR_SIZE;
+        bs->total_sectors = be64_to_cpu(footer->current_size) /
+                            BDRV_SECTOR_SIZE;
     }
 
     /* Allow a maximum disk size of approximately 2 TB */
@@ -868,7 +869,7 @@ static int vpc_create(const char *filename, QemuOpts *opts, Error **errp)
     footer->major = cpu_to_be16(0x0005);
     footer->minor = cpu_to_be16(0x0003);
     footer->orig_size = cpu_to_be64(total_size);
-    footer->size = cpu_to_be64(total_size);
+    footer->current_size = cpu_to_be64(total_size);
     footer->cyls = cpu_to_be16(cyls);
     footer->heads = heads;
     footer->secs_per_cyl = secs_per_cyl;
-- 
1.9.1

  parent reply	other threads:[~2015-03-03 10:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 10:41 [Qemu-devel] [PATCH v2 0/5] block/vpc optimizations Peter Lieven
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 1/5] block/vpc: optimize vpc_co_get_block_status Peter Lieven
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 2/5] vpc: Ignore geometry for large images Peter Lieven
2015-03-03 14:59   ` Max Reitz
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 3/5] block/vpc: make calculate_geometry spec conform Peter Lieven
2015-03-03 15:05   ` Max Reitz
2015-03-03 10:41 ` Peter Lieven [this message]
2015-03-03 10:41 ` [Qemu-devel] [PATCH v2 5/5] block/vpc: remove disabled code from get_sector_offset Peter Lieven
2015-03-03 15:07   ` Max Reitz
2015-03-03 21:03 ` [Qemu-devel] [PATCH v2 0/5] block/vpc optimizations Max Reitz
2015-03-17 21:02   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425379316-19639-5-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=carnold@suse.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).