From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSmwO-0002ne-Nj for qemu-devel@nongnu.org; Tue, 03 Mar 2015 08:32:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSmwJ-0002Om-Lk for qemu-devel@nongnu.org; Tue, 03 Mar 2015 08:32:52 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:43205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSmwJ-0002O4-Gr for qemu-devel@nongnu.org; Tue, 03 Mar 2015 08:32:47 -0500 Received: by wivr20 with SMTP id r20so22701914wiv.2 for ; Tue, 03 Mar 2015 05:32:46 -0800 (PST) Message-ID: <1425389563.7672.12.camel@profitbricks.com> From: Paulo Ricardo Paz Vital Date: Tue, 03 Mar 2015 14:32:43 +0100 In-Reply-To: <20150303140629.27c8fc91@nial.brq.redhat.com> References: <1425334488-28123-1-git-send-email-lcapitulino@redhat.com> <1425334488-28123-2-git-send-email-lcapitulino@redhat.com> <20150303140629.27c8fc91@nial.brq.redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-options.hx: improve -m description Reply-To: paulo.vital@profitbricks.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pkrempa@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino On Tue, 2015-03-03 at 14:06 +0100, Igor Mammedov wrote: > On Mon, 2 Mar 2015 17:14:47 -0500 > Luiz Capitulino wrote: > > > Add memory hotplug options to the command-line format. Also, > > add a complete command-line example and improve description. > > > > Signed-off-by: Luiz Capitulino > > --- > > qemu-options.hx | 23 ++++++++++++++++++----- > > 1 file changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/qemu-options.hx b/qemu-options.hx > > index 85ca3ad..6fa46d4 100644 > > --- a/qemu-options.hx > > +++ b/qemu-options.hx > > @@ -237,12 +237,25 @@ DEF("m", HAS_ARG, QEMU_OPTION_m, > > "NOTE: Some architectures might enforce a specific granularity\n", > > QEMU_ARCH_ALL) > > STEXI > > -@item -m [size=]@var{megs} > > +@item -m [size=]@var{megs}[,slots=n,maxmem=size] > > @findex -m > > -Set virtual RAM size to @var{megs} megabytes. Default is 128 MiB. Optionally, > > -a suffix of ``M'' or ``G'' can be used to signify a value in megabytes or > > -gigabytes respectively. Optional pair @var{slots}, @var{maxmem} could be used > > -to set amount of hotluggable memory slots and possible maximum amount of memory. > > +Sets guest startup RAM size to @var{megs} megabytes. Default is 128 MiB. > > +Optionally, a suffix of ``M'' or ``G'' can be used to signify a value in > > +megabytes or gigabytes respectively. Optional pair @var{slots}, @var{maxmem} > > +could be used to set amount of hotpluggable memory slots and maximum amount of > > +memory. Note that @var{maxmem} must be aligned to the page size. > > + > > +For example, the following command-line sets the guest startup RAM size to > > +1GB, creates 3 slots to hotplug additional memory and sets the maximum > > +memory the guest can reach to 4GB: > > + > > +@example > > +qemy-system-i386 -m 1G,slots=3,maxmem=4G > Perhaps it should be qemy-system-x86_64, > I'm not sure that -i386 target would work since hotplug memory is > mapped above 4G. Also it should be qemu, not qemy :-D > > > +@end example > > + > > +If @var{slots} and @var{maxmem} are not specified, memory hotplug won't > > +be enabled and the guest startup RAM will never increase (although it can > > +be decreased with the use of ballooning). > Technically that's not true, startup RAM is not decreased it's just landed out > by balloon driver to host. Is you restart guest it will use ALL startup memory > until the balloon driver is loaded. > I'd suggest to drop "(...)" part here. > > > ETEXI > > > > DEF("mem-path", HAS_ARG, QEMU_OPTION_mempath, > -- Paulo Ricardo Paz Vital ProfitBricks GmbH