From: Christian Borntraeger <borntraeger@de.ibm.com>
To: kwolf@redhat.com
Cc: thuth@linux.vnet.ibm.com,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-devel@nongnu.org, tumanova@linux.vnet.ibm.com,
armbru@redhat.com, mihajlov@linux.vnet.ibm.com,
dahi@linux.vnet.ibm.com, stefanha@redhat.com,
cornelia.huck@de.ibm.com, mreitz@redhat.com
Subject: [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property
Date: Tue, 3 Mar 2015 15:59:26 +0100 [thread overview]
Message-ID: <1425394766-12450-1-git-send-email-borntraeger@de.ibm.com> (raw)
Lets add a test for scsi devices without a drive. This was broken
by a recent block patch, thus indicating that we need a testcase.
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
tests/qemu-iotests/051 | 6 ++++++
tests/qemu-iotests/051.out | 8 ++++++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 11c858f..6ab40e2 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -95,6 +95,12 @@ run_qemu -drive file="$TEST_IMG",driver=foo
run_qemu -drive file="$TEST_IMG",driver=raw,format=qcow2
echo
+echo === Device without drive ===
+echo
+
+run_qemu -device virtio-scsi-pci -device scsi-hd
+
+echo
echo === Overriding backing file ===
echo
diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out
index f497c57..e8e3258 100644
--- a/tests/qemu-iotests/051.out
+++ b/tests/qemu-iotests/051.out
@@ -44,6 +44,14 @@ Testing: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2
QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=raw,format=qcow2: could not open disk image TEST_DIR/t.qcow2: Driver specified twice
+=== Device without drive ===
+
+Testing: -device virtio-scsi-pci -device scsi-hd
+QEMU X.Y.Z monitor - type 'help' for more information
+(qemu) QEMU_PROG: -device scsi-hd: drive property not set
+QEMU_PROG: -device scsi-hd: Device 'scsi-hd' could not be initialized
+
+
=== Overriding backing file ===
Testing: -drive file=TEST_DIR/t.qcow2,driver=qcow2,backing.file.filename=TEST_DIR/t.qcow2.orig -nodefaults
--
1.7.1
next reply other threads:[~2015-03-03 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 14:59 Christian Borntraeger [this message]
2015-03-03 15:19 ` [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property Max Reitz
2015-03-03 22:23 ` Stefan Hajnoczi
2015-03-04 12:26 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425394766-12450-1-git-send-email-borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=armbru@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@linux.vnet.ibm.com \
--cc=tumanova@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).