From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YStCC-0001DZ-72 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 15:13:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YStC8-000869-Dj for qemu-devel@nongnu.org; Tue, 03 Mar 2015 15:13:36 -0500 From: Max Reitz Date: Tue, 3 Mar 2015 15:13:02 -0500 Message-Id: <1425413591-31413-5-git-send-email-mreitz@redhat.com> In-Reply-To: <1425413591-31413-1-git-send-email-mreitz@redhat.com> References: <1425413591-31413-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v5 04/13] quorum: Fix close path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini , Max Reitz bdrv_unref() can lead to bdrv_close(), which in turn will result in bdrv_drain_all(). This function will later be called blk_drain_all() and iterate only over the BlockBackends for which blk_is_inserted() holds true; therefore, bdrv_is_inserted() and thus quorum_is_inserted() will probably be called. This patch makes quorum_is_inserted() aware of the fact that some children may have been closed already. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/quorum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 7a75cea..5ae2398 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -1005,6 +1005,7 @@ static void quorum_close(BlockDriverState *bs) for (i = 0; i < s->num_children; i++) { bdrv_unref(s->bs[i]); + s->bs[i] = NULL; } g_free(s->bs); @@ -1070,7 +1071,7 @@ static bool quorum_is_inserted(BlockDriverState *bs) int i; for (i = 0; i < s->num_children; i++) { - if (!bdrv_is_inserted(s->bs[i])) { + if (s->bs[i] && !bdrv_is_inserted(s->bs[i])) { return false; } } -- 2.1.0