From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSyrv-0003kC-5x for qemu-devel@nongnu.org; Tue, 03 Mar 2015 21:17:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSyrs-0004Yj-E7 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 21:17:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSyrs-0004Yf-6K for qemu-devel@nongnu.org; Tue, 03 Mar 2015 21:17:00 -0500 From: Eduardo Habkost Date: Tue, 3 Mar 2015 23:13:41 -0300 Message-Id: <1425435224-2630-3-git-send-email-ehabkost@redhat.com> In-Reply-To: <1425435224-2630-1-git-send-email-ehabkost@redhat.com> References: <1425435224-2630-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gu Zheng , Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Paolo Bonzini The existing apic_id = cpu_index code has no visible effect: the PC code already initializes the APIC ID according to the topology on pc_new_cpu(), and linux-user memcpy()s the CPU state (including cpuid_apic_id) on cpu_copy(). Remove the dead code and simply let APIC ID to to be 0 by default. This doesn't change behavior of PC because apic-id is already explicitly set, and doesn't affect linux-user because APIC ID was already always 0. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 8fc5727..05cac57 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2923,7 +2923,6 @@ static void x86_cpu_initfn(Object *obj) NULL, NULL, (void *)cpu->filtered_features, NULL); cpu->hyperv_spinlock_attempts = HYPERV_SPINLOCK_NEVER_RETRY; - env->cpuid_apic_id = x86_cpu_apic_id_from_index(cs->cpu_index); x86_cpu_load_def(cpu, xcc->cpu_def, &error_abort); -- 2.1.0