From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44624)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YT7lU-0007Xd-Fr
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 06:47:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YT7lR-0007BQ-Q3
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 06:47:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51194)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YT7lR-0007BH-IY
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 06:46:57 -0500
Message-ID: <1425469610.8389.29.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 04 Mar 2015 12:46:50 +0100
In-Reply-To: <20150304110444.GB27463@redhat.com>
References: <1425390913-17726-1-git-send-email-kraxel@redhat.com>
	<20150303174201.GD21824@redhat.com>
	<1425466550.8389.10.camel@nilsson.home.kraxel.org>
	<20150304110444.GB27463@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: make pci bar layout more
	flexible.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@kernel.org>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Mi, 2015-03-04 at 12:04 +0100, Michael S. Tsirkin wrote:
> On Wed, Mar 04, 2015 at 11:55:50AM +0100, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > > VirtIOPCIProxy subclasses which need additional pci bars, such as
> > > > virtio-vga, just need to make sure they register the additinal bars
> > > > before initializing virtio-pci, so the superclass can see the registered
> > > > bars and shuffle around the virtio bars accordingly.
> > > 
> > > I think I prefer we just DTRT and keep same layouts for everyone by
> > > default: isn't there a layout that is good for everybody?
> > 
> > I want bar #2 for the vga framebuffer for virtio-vga.  Which conflicts
> > with bar #2 being used for the modern bar in todays code.
> 
> OK, and IIUC you are saying that using bar #2 for that is a requirement for
> vga to work?

Makes things alot easier as seavgabios has support for virtio-vga (in
vga compat mode) already and expects the framebuffer being in bar #2.

It's not a _really_ hard requirement though.

cheers,
  Gerd