From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTAKG-0008GZ-6j for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:31:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTAK6-0004Bk-SQ for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:31:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTAK6-00049w-LT for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:30:54 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t24EUs5e006273 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 4 Mar 2015 09:30:54 -0500 From: Gerd Hoffmann Date: Wed, 4 Mar 2015 15:30:47 +0100 Message-Id: <1425479449-11480-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1425479449-11480-1-git-send-email-kraxel@redhat.com> References: <1425479449-11480-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 5/7] qxl: drop update_displaychangelistener call for secondary qxl devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Commit 3dcadce5076d4b42fa395c39662d65e050b77784 added three update_displaychangelistener call sites: Two for primary qxl cards, when entering/leaving vga mode, which are correct. One for secondary qxl cards, which is wrong because we don't register a displaychangelistener in the first place for secondary cards. Remove it. Reported-by: Brad Campbell Tested-by: Brad Campbell Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 94ff52a..762f75d 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1147,7 +1147,6 @@ static void qxl_soft_reset(PCIQXLDevice *d) qxl_enter_vga_mode(d); } else { d->mode = QXL_MODE_UNDEFINED; - update_displaychangelistener(&d->ssd.dcl, GUI_REFRESH_INTERVAL_IDLE); } } -- 1.8.3.1