From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTAKB-0008Ax-FP for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:31:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTAK8-0004D1-1R for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:30:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTAK7-0004CD-QJ for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:30:55 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t24EUscF029748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 4 Mar 2015 09:30:55 -0500 From: Gerd Hoffmann Date: Wed, 4 Mar 2015 15:30:49 +0100 Message-Id: <1425479449-11480-8-git-send-email-kraxel@redhat.com> In-Reply-To: <1425479449-11480-1-git-send-email-kraxel@redhat.com> References: <1425479449-11480-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 7/7] hmp: info spice: take out webdav List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Luiz Capitulino Obvious suggestion for the next spice-protocol release: Add some way to #ifdef new stuff. Signed-off-by: Gerd Hoffmann Reviewed-by: Cole Robinson --- hmp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hmp.c b/hmp.c index eacfb1b..71c28bc 100644 --- a/hmp.c +++ b/hmp.c @@ -561,7 +561,12 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict) [SPICE_CHANNEL_SMARTCARD] = "smartcard", [SPICE_CHANNEL_USBREDIR] = "usbredir", [SPICE_CHANNEL_PORT] = "port", +#if 0 + /* minimum spice-protocol is 0.12.3, webdav was added in 0.12.7, + * no easy way to #ifdef (SPICE_CHANNEL_* is a enum). Disable + * as quick fix for build failures with older versions. */ [SPICE_CHANNEL_WEBDAV] = "webdav", +#endif }; info = qmp_query_spice(NULL); -- 1.8.3.1