From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTCf3-000629-Hm for qemu-devel@nongnu.org; Wed, 04 Mar 2015 12:00:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTCex-000391-Lf for qemu-devel@nongnu.org; Wed, 04 Mar 2015 12:00:41 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTCex-00038l-Fz for qemu-devel@nongnu.org; Wed, 04 Mar 2015 12:00:35 -0500 Received: by widem10 with SMTP id em10so32400640wid.1 for ; Wed, 04 Mar 2015 09:00:34 -0800 (PST) Message-ID: <1425488430.14309.6.camel@profitbricks.com> From: Paulo Ricardo Paz Vital Date: Wed, 04 Mar 2015 18:00:30 +0100 In-Reply-To: <1425394046-20064-2-git-send-email-lcapitulino@redhat.com> References: <1425394046-20064-1-git-send-email-lcapitulino@redhat.com> <1425394046-20064-2-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-options.hx: improve -m description Reply-To: paulo.vital@profitbricks.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: imammedo@redhat.com, pkrempa@redhat.com, qemu-devel@nongnu.org On Tue, 2015-03-03 at 09:47 -0500, Luiz Capitulino wrote: > Add memory hotplug options to the command-line format. Also, > add a complete command-line example and improve description. > > Signed-off-by: Luiz Capitulino > --- > qemu-options.hx | 22 +++++++++++++++++----- > 1 file changed, 17 insertions(+), 5 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 85ca3ad..b0345ae 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -237,12 +237,24 @@ DEF("m", HAS_ARG, QEMU_OPTION_m, > "NOTE: Some architectures might enforce a specific granularity\n", > QEMU_ARCH_ALL) > STEXI > -@item -m [size=]@var{megs} > +@item -m [size=]@var{megs}[,slots=n,maxmem=size] > @findex -m > -Set virtual RAM size to @var{megs} megabytes. Default is 128 MiB. Optionally, > -a suffix of ``M'' or ``G'' can be used to signify a value in megabytes or > -gigabytes respectively. Optional pair @var{slots}, @var{maxmem} could be used > -to set amount of hotluggable memory slots and possible maximum amount of memory. > +Sets guest startup RAM size to @var{megs} megabytes. Default is 128 MiB. > +Optionally, a suffix of ``M'' or ``G'' can be used to signify a value in > +megabytes or gigabytes respectively. Optional pair @var{slots}, @var{maxmem} > +could be used to set amount of hotpluggable memory slots and maximum amount of > +memory. Note that @var{maxmem} must be aligned to the page size. > + > +For example, the following command-line sets the guest startup RAM size to > +1GB, creates 3 slots to hotplug additional memory and sets the maximum > +memory the guest can reach to 4GB: > + > +@example > +qemu-system-x86_64 -m 1G,slots=3,maxmem=4G > +@end example > + > +If @var{slots} and @var{maxmem} are not specified, memory hotplug won't > +be enabled and the guest startup RAM will never increase. > ETEXI > > DEF("mem-path", HAS_ARG, QEMU_OPTION_mempath, Reviewed-by: Paulo Vital