From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 2/2] qmp: Drop unused .user_print from command definitions
Date: Fri, 6 Mar 2015 10:09:58 +0100 [thread overview]
Message-ID: <1425632998-616-3-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1425632998-616-1-git-send-email-armbru@redhat.com>
.user_print isn't used with QMP commands, only with HMP commands.
Copied over when QMP got its own command table in commit 82a56f0.
Most of them have been dropped since, but a few stragglers remain.
Drop them.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qmp-commands.hx | 4 ----
1 file changed, 4 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index a85d847..2c05e87 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -276,7 +276,6 @@ EQMP
.args_type = "device:O",
.params = "driver[,prop=value][,...]",
.help = "add device, like -device on the command line",
- .user_print = monitor_user_noop,
.mhandler.cmd_new = do_device_add,
},
@@ -757,7 +756,6 @@ EQMP
.args_type = "protocol:s,hostname:s,port:i?,tls-port:i?,cert-subject:s?",
.params = "protocol hostname port tls-port cert-subject",
.help = "send migration info to spice/vnc client",
- .user_print = monitor_user_noop,
.mhandler.cmd_async = client_migrate_info,
.flags = MONITOR_CMD_ASYNC,
},
@@ -793,7 +791,6 @@ EQMP
.args_type = "paging:b,protocol:s,begin:i?,end:i?,format:s?",
.params = "-p protocol [begin] [length] [format]",
.help = "dump guest memory to file",
- .user_print = monitor_user_noop,
.mhandler.cmd_new = qmp_marshal_input_dump_guest_memory,
},
@@ -1833,7 +1830,6 @@ EQMP
.args_type = "",
.params = "",
.help = "enable QMP capabilities",
- .user_print = monitor_user_noop,
.mhandler.cmd_new = do_qmp_capabilities,
},
--
1.9.3
next prev parent reply other threads:[~2015-03-06 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 9:09 [Qemu-devel] [PATCH 0/2] monitor: Fix and clean up around .user_print Markus Armbruster
2015-03-06 9:09 ` [Qemu-devel] [PATCH 1/2] hmp: Fix definition of command quit Markus Armbruster
2015-03-06 9:09 ` Markus Armbruster [this message]
2015-03-06 15:57 ` [Qemu-devel] [PATCH 0/2] monitor: Fix and clean up around .user_print Eric Blake
2015-03-10 6:09 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425632998-616-3-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).